第 14 章 Successive Refinement

    This chapter is a case study in successive refinement. You will see a module that started well but did not scale. Then you will see how the module was refactored and cleaned.

    Most of us have had to parse command-line arguments from time to time. If we don’t have a convenient utility, then we simply walk the array of strings that is passed into the main function. There are several good utilities available from various sources, but none of them do exactly what I want. So, of course, I decided to write my own. I call it: Args.

    Args is very simple to use. You simply construct the Args class with the input arguments and a format string, and then query the Args instance for the values of the arguments. Consider the following simple example:

    Listing 14-1 Simple use of Args

    You can see how simple this is. We just create an instance of the Args class with two parameters. The first parameter is the format, or schema, string: “l,p#,d*.” It defines three command-line arguments. The first, -l, is a boolean argument. The second, -p, is an integer argument. The third, -d, is a string argument. The second parameter to the Args constructor is simply the array of command-line argument passed into main.

    If the constructor returns without throwing an ArgsException, then the incoming command-line was parsed, and the Args instance is ready to be queried. Methods like getBoolean, getInteger, and getString allow us to access the values of the arguments by their names.

    If there is a problem, either in the format string or in the command-line arguments themselves, an ArgsException will be thrown. A convenient description of what went wrong can be retrieved from the errorMessage method of the exception.

    ARGS IMPLEMENTATION Listing 14-2 is the implementation of the Args class. Please read it very carefully. I worked hard on the style and structure and hope it is worth emulating.

    Listing 14-2 Args.java

    3. import static com.objectmentor.utilities.args.ArgsException.ErrorCode.*;
    5. import java.util.*;
    7. public class Args {
    8.     private Map<Character, ArgumentMarshaler> marshalers;
    9.     private Set<Character> argsFound;
    10.     private ListIterator<String> currentArgument;
    12.     public Args(String schema, String[] args) throws ArgsException {
    13.         marshalers = new HashMap<Character, ArgumentMarshaler>();
    14.         argsFound = new HashSet<Character>();
    16.         parseSchema(schema);
    17.         parseArgumentStrings(Arrays.asList(args));
    18.     }
    20.     private void parseSchema(String schema) throws ArgsException {
    21.         for (String element : schema.split(","))
    22.             if (element.length() > 0)
    23.                 parseSchemaElement(element.trim());
    24.     }
    26.     private void parseSchemaElement(String element) throws ArgsException {
    27.         char elementId = element.charAt(0);
    28.         String elementTail = element.substring(1);
    29.         validateSchemaElementId(elementId);
    30.         if (elementTail.length() == 0)
    31.             marshalers.put(elementId, new BooleanArgumentMarshaler());
    32.         else if (elementTail.equals("*"))
    33.             marshalers.put(elementId, new StringArgumentMarshaler());
    34.         else if (elementTail.equals("#"))
    35.             marshalers.put(elementId, new IntegerArgumentMarshaler());
    36.         else if (elementTail.equals("##"))
    37.             marshalers.put(elementId, new DoubleArgumentMarshaler());
    38.         else if (elementTail.equals("[*]"))
    39.             marshalers.put(elementId, new StringArrayArgumentMarshaler());
    40.         else
    41.             throw new ArgsException(INVALID_ARGUMENT_FORMAT, elementId, elementTail);
    42.     }
    44.     private void validateSchemaElementId(char elementId) throws ArgsException {
    45.         if (!Character.isLetter(elementId))
    46.             throw new ArgsException(INVALID_ARGUMENT_NAME, elementId, null);
    47.     }
    49.     private void parseArgumentStrings(List<String> argsList) throws ArgsException {
    50.         for (currentArgument = argsList.listIterator(); currentArgument.hasNext(); ) {
    51.             String argString = currentArgument.next();
    52.             if (argString.startsWith("-")) {
    53.                 parseArgumentCharacters(argString.substring(1));
    54.             } else {
    55.                 currentArgument.previous();
    56.                 break;
    57.             }
    58.         }
    59.     }
    61.     private void parseArgumentCharacters(String argChars) throws ArgsException {
    62.         for (int i = 0; i < argChars.length(); i++)
    63.             parseArgumentCharacter(argChars.charAt(i));
    64.     }
    66.     private void parseArgumentCharacter(char argChar) throws ArgsException {
    67.         ArgumentMarshaler m = marshalers.get(argChar);
    68.         if (m == null) {
    69.             throw new ArgsException(UNEXPECTED_ARGUMENT, argChar, null);
    70.         } else {
    71.             argsFound.add(argChar);
    72.             try {
    73.                 m.set(currentArgument);
    74.             } catch (ArgsException e) {
    75.                 e.setErrorArgumentId(argChar);
    76.                 throw e;
    77.             }
    78.         }
    79.     }
    81.     public boolean has(char arg) {
    82.         return argsFound.contains(arg);
    83.     }
    85.     public int nextArgument() {
    86.         return currentArgument.nextIndex();
    87.     }
    89.     public boolean getBoolean(char arg) {
    90.         return BooleanArgumentMarshaler.getValue(marshalers.get(arg));
    91.     }
    93.     public String getString(char arg) {
    94.         return StringArgumentMarshaler.getValue(marshalers.get(arg));
    95.     }
    97.     public int getInt(char arg) {
    98.         return IntegerArgumentMarshaler.getValue(marshalers.get(arg));
    99.     }
    101.     public double getDouble(char arg) {
    102.         return DoubleArgumentMarshaler.getValue(marshalers.get(arg));
    103.     }
    105.     public String[] getStringArray(char arg) {
    106.         return StringArrayArgumentMarshaler.getValue(marshalers.get(arg));
    107.     }
    108. }

    Notice that you can read this code from the top to the bottom without a lot of jumping around or looking ahead. The one thing you may have had to look ahead for is the definition of ArgumentMarshaler, which I left out intentionally. Having read this code carefully, you should understand what the ArgumentMarshaler interface is and what its derivatives do. I’ll show a few of them to you now (Listing 14-3 through Listing 14-6).

    Listing 14-3 ArgumentMarshaler.java

    1. public interface ArgumentMarshaler {
    2.     void set(Iterator<String> currentArgument) throws ArgsException;
    3. }

    Listing 14-4 BooleanArgumentMarshaler.java

    1. public class BooleanArgumentMarshaler implements ArgumentMarshaler {
    2.     private boolean booleanValue = false;
    4.     public void set(Iterator<String> currentArgument) throws ArgsException {
    5.         booleanValue = true;
    6.     }
    8.     public static boolean getValue(ArgumentMarshaler am) {
    9.         if (am != null && am instanceof BooleanArgumentMarshaler)
    10.             return ((BooleanArgumentMarshaler) am).booleanValue;
    11.         else
    12.             return false;
    13.     }
    14. }

    Listing 14-5 StringArgumentMarshaler.java

    1. import static com.objectmentor.utilities.args.ArgsException.ErrorCode.*;
    3. public class StringArgumentMarshaler implements ArgumentMarshaler {
    4.     private String stringValue =
    6.     public void set(Iterator<String> currentArgument) throws ArgsException {
    7.         try {
    8.             stringValue = currentArgument.next();
    9.         } catch (NoSuchElementException e) {
    10.             throw new ArgsException(MISSING_STRING);
    11.         }
    12.     }
    14.     public static String getValue(ArgumentMarshaler am) {
    15.         if (am != null && am instanceof StringArgumentMarshaler)
    16.             return ((StringArgumentMarshaler) am).stringValue;
    17.         else
    18.             return "";
    19.     }
    20. }

    The other ArgumentMarshaler derivatives simply replicate this pattern for doubles and String arrays and would serve to clutter this chapter. I’ll leave them to you as an exercise.

    One other bit of information might be troubling you: the definition of the error code constants. They are in the ArgsException class (Listing 14-7).

    Listing 14-6 IntegerArgumentMarshaler.java

    1. import static com.objectmentor.utilities.args.ArgsException.ErrorCode.*;
    3. public class IntegerArgumentMarshaler implements ArgumentMarshaler {
    4.     private int intValue = 0;
    6.     public void set(Iterator<String> currentArgument) throws ArgsException {
    7.         String parameter = null;
    8.         try {
    9.             parameter = currentArgument.next();
    10.             intValue = Integer.parseInt(parameter);
    11.         } catch (NoSuchElementException e) {
    12.             throw new ArgsException(MISSING_INTEGER);
    13.         } catch (NumberFormatException e) {
    14.             throw new ArgsException(INVALID_INTEGER, parameter);
    15.         }
    16.     }
    18.     public static int getValue(ArgumentMarshaler am) {
    19.         if (am != null && am instanceof IntegerArgumentMarshaler)
    20.             return ((IntegerArgumentMarshaler) am).intValue;
    21.         else
    22.             return 0;
    23.     }
    24. }

    Listing 14-7 ArgsException.java

    1. import static com.objectmentor.utilities.args.ArgsException.ErrorCode.*;
    3. public class ArgsException extends Exception {
    4.     private char errorArgumentId = '\0';
    5.     private String errorParameter = null;
    6.     private ErrorCode errorCode = OK;
    8.     public ArgsException() {
    9.     }
    11.     public ArgsException(String message) {
    12.         super(message);
    13.     }
    15.     public ArgsException(ErrorCode errorCode) {
    16.         this.errorCode = errorCode;
    17.     }
    19.     public ArgsException(ErrorCode errorCode, String errorParameter) {
    20.         this.errorCode = errorCode;
    21.         this.errorParameter = errorParameter;
    22.     }
    24.     public ArgsException(ErrorCode errorCode,
    25.                          char errorArgumentId, String errorParameter) {
    26.         this.errorCode = errorCode;
    27.         this.errorParameter = errorParameter;
    28.         this.errorArgumentId = errorArgumentId;
    29.     }
    31.     public char getErrorArgumentId() {
    32.         return errorArgumentId;
    33.     }
    35.     public void setErrorArgumentId(char errorArgumentId) {
    36.         this.errorArgumentId = errorArgumentId;
    37.     }
    39.     public String getErrorParameter() {
    40.         return errorParameter;
    41.     }
    43.     public void setErrorParameter(String errorParameter) {
    44.         this.errorParameter = errorParameter;
    45.     }
    47.     public ErrorCode getErrorCode() {
    48.         return errorCode;
    49.     }
    51.     public void setErrorCode(ErrorCode errorCode) {
    52.         this.errorCode = errorCode;
    53.     }
    55.     public String errorMessage() {
    56.         switch (errorCode) {
    57.             case OK:
    58.                 return "TILT: Should not get here.";
    59.             case UNEXPECTED_ARGUMENT:
    60.                 return String.format("Argument -%c unexpected.", errorArgumentId);
    61.             case MISSING_STRING:
    62.                 return String.format("Could not find string parameter for -%c.",
    63.                         errorArgumentId);
    64.             case INVALID_INTEGER:
    65.                 return String.format("Argument -%c expects an integer but was '%s'.",
    66.                         errorArgumentId, errorParameter);
    67.             case MISSING_INTEGER:
    68.                 return String.format("Could not find integer parameter for -%c.",
    69.                         errorArgumentId);
    70.             case INVALID_DOUBLE:
    71.                 return String.format("Argument -%c expects a double but was '%s'.",
    72.                         errorArgumentId, errorParameter);
    73.             case MISSING_DOUBLE:
    74.                 return String.format("Could not find double parameter for -%c.",
    75.                         errorArgumentId);
    76.             case INVALID_ARGUMENT_NAME:
    77.                 return String.format("'%c' is not a valid argument name.",
    78.                         errorArgumentId);
    79.             case INVALID_ARGUMENT_FORMAT:
    80.                 return String.format("'%s' is not a valid argument format.",
    81.                         errorParameter);
    82.         }
    83.         return "";
    84.     }
    86.     public enum ErrorCode {
    87.         OK, INVALID_ARGUMENT_FORMAT, UNEXPECTED_ARGUMENT, INVALID_ARGUMENT_NAME,
    88.         MISSING_STRING,
    89.         MISSING_INTEGER, INVALID_INTEGER,
    90.         MISSING_DOUBLE, INVALID_DOUBLE
    91.     }
    92. }

    It’s remarkable how much code is required to flesh out the details of this simple concept. One of the reasons for this is that we are using a particularly wordy language. Java, being a statically typed language, requires a lot of words in order to satisfy the type system. In a language like Ruby, Python, or Smalltalk, this program is much smaller.1

    Please read the code over one more time. Pay special attention to the way things are named, the size of the functions, and the formatting of the code. If you are an experienced programmer, you may have some quibbles here and there with various parts of the style or structure. Overall, however, I hope you conclude that this program is nicely written and has a clean structure.

    For example, it should be obvious how you would add a new argument type, such as a date argument or a complex number argument, and that such an addition would require a trivial amount of effort. In short, it would simply require a new derivative of Argument-Marshaler, a new getXXX function, and a new case statement in the parseSchemaElement function. There would also probably be a new ArgsException.ErrorCode and a new error message.

    How Did I Do This? Let me set your mind at rest. I did not simply write this program from beginning to end in its current form. More importantly, I am not expecting you to be able to write clean and elegant programs in one pass. If we have learned anything over the last couple of decades, it is that programming is a craft more than it is a science. To write clean code, you must first write dirty code and then clean it.

    This should not be a surprise to you. We learned this truth in grade school when our teachers tried (usually in vain) to get us to write rough drafts of our compositions. The process, they told us, was that we should write a rough draft, then a second draft, then several subsequent drafts until we had our final version. Writing clean compositions, they tried to tell us, is a matter of successive refinement.

    Most freshman programmers (like most grade-schoolers) don’t follow this advice particularly well. They believe that the primary goal is to get the program working. Once it’s “working,” they move on to the next task, leaving the “working” program in whatever state they finally got it to “work.” Most seasoned programmers know that this is professional suicide.

    ARGS: THE ROUGH DRAFT Listing 14-8 shows an earlier version of the Args class. It “works.” And it’s messy.

    Listing 14-8 Args.java (first draft)

    1. import java.text.ParseException;
    2. import java.util.*;
    4. public class Args {
    5.     private String schema;
    6.     private String[] args;
    7.     private boolean valid = true;
    8.     private Set<Character> unexpectedArguments = new TreeSet<Character>();
    9.     private Map<Character, Boolean> booleanArgs =
    10.             new HashMap
    11.                     <Character, Boolean>();
    12.     private Map<Character, String> stringArgs = new HashMap
    13.             <Character, String>();
    14.     private Map<Character, Integer> intArgs = new HashMap<Character, Integer>();
    15.     private Set<Character> argsFound = new HashSet<Character>();
    16.     private int currentArgument;
    17.     private char errorArgumentId = '\0';
    18.     private String errorParameter = "TILT";
    19.     private ErrorCode errorCode = ErrorCode.OK;
    21.     private enum ErrorCode {
    22.         OK, MISSING_STRING, MISSING_INTEGER, INVALID_INTEGER, UNEXPECTED_ARGUMENT
    23.     }
    25.     public Args(String schema, String[] args) throws ParseException {
    26.         this.schema = schema;
    27.         this.args = args;
    28.         valid = parse();
    29.     }
    31.     private boolean parse() throws ParseException {
    32.         if (schema.length() == 0 && args.length == 0)
    33.             return true;
    34.         parseSchema();
    35.         try {
    36.             parseArguments();
    37.         } catch (ArgsException e) {
    38.         }
    39.         return valid;
    40.     }
    42.     private boolean parseSchema() throws ParseException {
    43.         for (String element : schema.split(",")) {
    44.             if (element.length() > 0) {
    45.                 String trimmedElement = element.trim();
    46.                 parseSchemaElement(trimmedElement);
    47.             }
    48.         }
    49.         return true;
    50.     }
    52.     private void parseSchemaElement(String element) throws ParseException {
    53.         char elementId = element.charAt(0);
    54.         String elementTail = element.substring(1);
    55.         validateSchemaElementId(elementId);
    56.         if (isBooleanSchemaElement(elementTail))
    57.             parseBooleanSchemaElement(elementId);
    58.         else if (isStringSchemaElement(elementTail))
    59.             parseStringSchemaElement(elementId);
    60.         else if (isIntegerSchemaElement(elementTail)) {
    61.             parseIntegerSchemaElement(elementId);
    62.         } else {
    63.             throw new ParseException(
    64.                     String.format("Argument: %c has invalid format: %s.",
    65.                             elementId, elementTail), 0);
    66.         }
    67.     }
    69.     private void validateSchemaElementId(char elementId) throws ParseException {
    70.         if (!Character.isLetter(elementId)) {
    71.             throw new ParseException(
    72.                     "Bad character:" + elementId + "in Args format: " + schema, 0);
    73.         }
    74.     }
    76.     private void parseBooleanSchemaElement(char elementId) {
    77.         booleanArgs.put(elementId, false);
    78.     }
    80.     private void parseIntegerSchemaElement(char elementId) {
    81.         intArgs.put(elementId, 0);
    82.     }
    84.     private void parseStringSchemaElement(char elementId) {
    85.         stringArgs.put(elementId, "");
    86.     }
    88.     private boolean isStringSchemaElement(String elementTail) {
    89.         return elementTail.equals("*");
    90.     }
    92.     private boolean isBooleanSchemaElement(String elementTail) {
    93.         return elementTail.length() == 0;
    94.     }
    96.     private boolean isIntegerSchemaElement(String elementTail) {
    97.         return elementTail.equals("#");
    98.     }
    100.     private boolean parseArguments() throws ArgsException {
    101.         for (currentArgument = 0; currentArgument < args.length; currentArgument++) {
    102.             String arg = args[currentArgument];
    103.             parseArgument(arg);
    104.         }
    105.         return true;
    106.     }
    108.     private void parseArgument(String arg) throws ArgsException {
    109.         if (arg.startsWith("-"))
    110.             parseElements(arg);
    111.     }
    113.     private void parseElements(String arg) throws ArgsException {
    114.         for (int i = 1; i < arg.length(); i++)
    115.             parseElement(arg.charAt(i));
    116.     }
    118.     private void parseElement(char argChar) throws ArgsException {
    119.         if (setArgument(argChar))
    120.             argsFound.add(argChar);
    121.         else {
    122.             unexpectedArguments.add(argChar);
    123.             errorCode = ErrorCode.UNEXPECTED_ARGUMENT;
    124.             valid = false;
    125.         }
    126.     }
    128.     private boolean setArgument(char argChar) throws ArgsException {
    129.         if (isBooleanArg(argChar))
    130.             setBooleanArg(argChar, true);
    131.         else if (isStringArg(argChar))
    132.             setStringArg(argChar);
    133.         else if (isIntArg(argChar))
    134.             setIntArg(argChar);
    135.         else
    136.             return false;
    138.         return true;
    139.     }
    141.     private boolean isIntArg(char argChar) {
    142.         return intArgs.containsKey(argChar);
    143.     }
    145.     private void setIntArg(char argChar) throws ArgsException {
    146.         currentArgument++;
    147.         String parameter = null;
    148.         try {
    149.             parameter = args[currentArgument];
    150.             intArgs.put(argChar, new Integer(parameter));
    151.         } catch (ArrayIndexOutOfBoundsException e) {
    152.             valid = false;
    153.             errorArgumentId = argChar;
    154.             errorCode = ErrorCode.MISSING_INTEGER;
    156.             throw new ArgsException();
    157.         } catch (NumberFormatException e) {
    158.             valid = false;
    159.             errorArgumentId = argChar;
    160.             errorParameter = parameter;
    161.             errorCode = ErrorCode.INVALID_INTEGER;
    162.             throw new ArgsException();
    163.         }
    164.     }
    166.     private void setStringArg(char argChar) throws ArgsException {
    167.         currentArgument++;
    168.         try {
    169.             stringArgs.put(argChar, args[currentArgument]);
    170.         } catch (ArrayIndexOutOfBoundsException e) {
    171.             valid = false;
    172.             errorArgumentId = argChar;
    173.             errorCode = ErrorCode.MISSING_STRING;
    174.             throw new ArgsException();
    175.         }
    176.     }
    178.     private boolean isStringArg(char argChar) {
    179.         return stringArgs.containsKey(argChar);
    180.     }
    182.     private void setBooleanArg(char argChar, boolean value) {
    183.         booleanArgs.put(argChar, value);
    184.     }
    186.     private boolean isBooleanArg(char argChar) {
    187.         return booleanArgs.containsKey(argChar);
    188.     }
    190.     public int cardinality() {
    191.         return argsFound.size();
    192.     }
    194.     public String usage() {
    195.         if (schema.length() > 0)
    196.             return "-[" + schema + "]";
    197.         else
    198.             return "";
    199.     }
    201.     public String errorMessage() throws Exception {
    202.         switch (errorCode) {
    203.             case OK:
    204.                 throw new Exception("TILT: Should not get here.");
    205.             case UNEXPECTED_ARGUMENT:
    206.                 return unexpectedArgumentMessage();
    207.             case MISSING_STRING:
    208.                 return String.format("Could not find string parameter for -%c.",
    209.                         errorArgumentId);
    211.             case INVALID_INTEGER:
    212.                 return String.format("Argument -%c expects an integer but was '%s'.",
    213.                         errorArgumentId, errorParameter);
    214.             case MISSING_INTEGER:
    215.                 return String.format("Could not find integer parameter for -%c.",
    216.                         errorArgumentId);
    217.         }
    218.         return "";
    219.     }
    221.     private String unexpectedArgumentMessage() {
    222.         StringBuffer message = new StringBuffer("Argument(s) -");
    223.         for (char c : unexpectedArguments) {
    224.             message.append(c);
    225.         }
    226.         message.append(" unexpected.");
    228.         return message.toString();
    229.     }
    231.     private boolean falseIfNull(Boolean b) {
    232.         return b != null && b;
    233.     }
    235.     private int zeroIfNull(Integer i) {
    236.         return i == null ? 0 : i;
    237.     }
    239.     private String blankIfNull(String s) {
    240.         return s == null ? "" : s;
    241.     }
    243.     public String getString(char arg) {
    244.         return blankIfNull(stringArgs.get(arg));
    245.     }
    247.     public int getInt(char arg) {
    248.         return zeroIfNull(intArgs.get(arg));
    249.     }
    251.     public boolean getBoolean(char arg) {
    252.         return falseIfNull(booleanArgs.get(arg));
    253.     }
    255.     public boolean has(char arg) {
    256.         return argsFound.contains(arg);
    257.     }
    259.     public boolean isValid() {
    260.         return valid;
    261.     }
    263.     private class ArgsException extends Exception {
    264.     }
    265. }

    I hope your initial reaction to this mass of code is “I’m certainly glad he didn’t leave it like that!” If you feel like this, then remember that’s how other people are going to feel about code that you leave in rough-draft form.

    Actually “rough draft” is probably the kindest thing you can say about this code. It’s clearly a work in progress. The sheer number of instance variables is daunting. The odd strings like “TILT,” the HashSets and TreeSets, and the try-catch-catch blocks all add up to a festering pile.

    I had not wanted to write a festering pile. Indeed, I was trying to keep things reasonably well organized. You can probably tell that from my choice of function and variable names and the fact that there is a crude structure to the program. But, clearly, I had let the problem get away from me.

    The mess built gradually. Earlier versions had not been nearly so nasty. For example, Listing 14-9 shows an earlier version in which only Boolean arguments were working.

    Listing 14-9 Args.java (Boolean only)

    1. package com.objectmentor.utilities.getopts;
    3. import java.util.*;
    5. public class Args {
    6.     private String schema;
    7.     private String[] args;
    8.     private boolean valid;
    9.     private Set<Character> unexpectedArguments = new TreeSet<Character>();
    10.     private Map<Character, Boolean> booleanArgs =
    11.             new HashMap<Character, Boolean>();
    12.     private int numberOfArguments = 0;
    14.     public Args(String schema, String[] args) {
    15.         this.schema = schema;
    16.         this.args = args;
    17.         valid = parse();
    18.     }
    20.     public boolean isValid() {
    21.         return valid;
    22.     }
    24.     private boolean parse() {
    25.         if (schema.length() == 0 && args.length == 0)
    26.             return true;
    27.         parseSchema();
    28.         parseArguments();
    29.         return unexpectedArguments.size() == 0;
    30.     }
    32.     private boolean parseSchema() {
    33.         for (String element : schema.split(",")) {
    34.             parseSchemaElement(element);
    35.         }
    36.         return true;
    37.     }
    39.     private void parseSchemaElement(String element) {
    40.         if (element.length() == 1) {
    41.             parseBooleanSchemaElement(element);
    42.         }
    43.     }
    45.     private void parseBooleanSchemaElement(String element) {
    46.         char c = element.charAt(0);
    47.         if (Character.isLetter(c)) {
    48.             booleanArgs.put(c, false);
    49.         }
    50.     }
    52.     private boolean parseArguments() {
    53.         for (String arg : args)
    54.             parseArgument(arg);
    55.         return true;
    56.     }
    58.     private void parseArgument(String arg) {
    59.         if (arg.startsWith("-"))
    60.             parseElements(arg);
    61.     }
    63.     private void parseElements(String arg) {
    64.         for (int i = 1; i < arg.length(); i++)
    65.             parseElement(arg.charAt(i));
    66.     }
    68.     private void parseElement(char argChar) {
    69.         if (isBoolean(argChar)) {
    70.             numberOfArguments++;
    71.             setBooleanArg(argChar, true);
    72.         } else
    73.             unexpectedArguments.add(argChar);
    74.     }
    76.     private void setBooleanArg(char argChar, boolean value) {
    77.         booleanArgs.put(argChar, value);
    78.     }
    80.     private boolean isBoolean(char argChar) {
    81.         return booleanArgs.containsKey(argChar);
    82.     }
    84.     public int cardinality() {
    85.         return numberOfArguments;
    86.     }
    88.     public String usage() {
    89.         if (schema.length() > 0)
    90.             return "-[" + schema + "]";
    91.         else
    92.             return "";
    93.     }
    95.     public String errorMessage() {
    96.         if (unexpectedArguments.size() > 0) {
    97.             return unexpectedArgumentMessage();
    98.         } else
    99.             return "";
    100.     }
    102.     private String unexpectedArgumentMessage() {
    103.         StringBuffer message = new StringBuffer("Argument(s) -");
    104.         for (char c : unexpectedArguments) {
    105.             message.append(c);
    106.         }
    107.         message.append(" unexpected.");
    109.         return message.toString();
    110.     }
    112.     public boolean getBoolean(char arg) {
    113.         return booleanArgs.get(arg);
    114.     }
    115. }

    Although you can find plenty to complain about in this code, it’s really not that bad. It’s compact and simple and easy to understand. However, within this code it is easy to see the seeds of the later festering pile. It’s quite clear how this grew into the latter mess.

    Notice that the latter mess has only two more argument types than this: String and integer. The addition of just two more argument types had a massively negative impact on the code. It converted it from something that would have been reasonably maintainable into something that I would expect to become riddled with bugs and warts.

    I added the two argument types incrementally. First, I added the String argument, which yielded this:

    Listing 14-10 Args.java (Boolean and String)

    1. package com.objectmentor.utilities.getopts;
    3. import java.text.ParseException;
    4. import java.util.*;
    6. public class Args {
    7.     private String schema;
    8.     private String[] args;
    9.     private boolean valid = true;
    10.     private Set<Character> unexpectedArguments = new TreeSet<Character>();
    11.     private Map<Character, Boolean> booleanArgs =
    12.             new HashMap<Character, Boolean>();
    13.     private Map<Character, String> stringArgs =
    14.             new HashMap<Character, String>();
    15.     private Set<Character> argsFound = new HashSet<Character>();
    16.     private int currentArgument;
    17.     private char errorArgument = '\0';
    19.     enum ErrorCode {
    20.         OK, MISSING_STRING
    21.     }
    23.     private ErrorCode errorCode = ErrorCode.OK;
    25.     public Args(String schema, String[] args) throws ParseException {
    26.         this.schema = schema;
    27.         this.args = args;
    28.         valid = parse();
    29.     }
    31.     private boolean parse() throws ParseException {
    32.         if (schema.length() == 0 && args.length == 0)
    33.             return true;
    34.         parseSchema();
    35.         parseArguments();
    36.         return valid;
    37.     }
    39.     private boolean parseSchema() throws ParseException {
    40.         for (String element : schema.split(",")) {
    41.             if (element.length() > 0) {
    42.                 String trimmedElement = element.trim();
    43.                 parseSchemaElement(trimmedElement);
    44.             }
    45.         }
    46.         return true;
    47.     }
    49.     private void parseSchemaElement(String element) throws ParseException {
    50.         char elementId = element.charAt(0);
    51.         String elementTail = element.substring(1);
    52.         validateSchemaElementId(elementId);
    53.         if (isBooleanSchemaElement(elementTail))
    54.             parseBooleanSchemaElement(elementId);
    55.         else if (isStringSchemaElement(elementTail))
    56.             parseStringSchemaElement(elementId);
    57.     }
    59.     private void validateSchemaElementId(char elementId) throws ParseException {
    60.         if (!Character.isLetter(elementId)) {
    61.             throw new ParseException(
    62.                     "Bad character:" + elementId + "in Args format: " + schema, 0);
    63.         }
    64.     }
    66.     private void parseStringSchemaElement(char elementId) {
    67.         stringArgs.put(elementId, " ");
    68.     }
    71.     private boolean isStringSchemaElement(String elementTail) {
    72.         return elementTail.equals("*");
    73.     }
    75.     private boolean isBooleanSchemaElement(String elementTail) {
    76.         return elementTail.length() == 0;
    77.     }
    79.     private void parseBooleanSchemaElement(char elementId) {
    80.         booleanArgs.put(elementId, false);
    81.     }
    83.     private boolean parseArguments() {
    84.         for (currentArgument = 0; currentArgument < args.length; currentArgument++) {
    85.             String arg = args[currentArgument];
    86.             parseArgument(arg);
    87.         }
    88.         return true;
    89.     }
    91.     private void parseArgument(String arg) {
    92.         if (arg.startsWith("-"))
    93.             parseElements(arg);
    94.     }
    96.     private void parseElements(String arg) {
    97.         for (int i = 1; i < arg.length(); i++)
    98.             parseElement(arg.charAt(i));
    99.     }
    101.     private void parseElement(char argChar) {
    102.         if (setArgument(argChar))
    103.             argsFound.add(argChar);
    104.         else {
    105.             unexpectedArguments.add(argChar);
    106.             valid = false;
    107.         }
    108.     }
    110.     private boolean setArgument(char argChar) {
    111.         boolean set = true;
    112.         if (isBoolean(argChar))
    113.             setBooleanArg(argChar, true);
    114.         else if (isString(argChar))
    115.             setStringArg(argChar, " ");
    116.         else
    117.             set = false;
    119.         return set;
    120.     }
    122.     private void setStringArg(char argChar, String s) {
    123.         currentArgument++;
    124.         try {
    125.             stringArgs.put(argChar, args[currentArgument]);
    126.         } catch (ArrayIndexOutOfBoundsException e) {
    127.             valid = false;
    128.             errorArgument = argChar;
    129.             errorCode = ErrorCode.MISSING_STRING;
    130.         }
    131.     }
    133.     private boolean isString(char argChar) {
    134.         return stringArgs.containsKey(argChar);
    135.     }
    137.     private void setBooleanArg(char argChar, boolean value) {
    138.         booleanArgs.put(argChar, value);
    139.     }
    141.     private boolean isBoolean(char argChar) {
    142.         return booleanArgs.containsKey(argChar);
    143.     }
    145.     public int cardinality() {
    146.         return argsFound.size();
    147.     }
    149.     public String usage() {
    150.         if (schema.length() > 0)
    151.             return "-[" + schema + "]";
    152.         else
    153.             return " ";
    154.     }
    156.     public String errorMessage() throws Exception {
    157.         if (unexpectedArguments.size() > 0) {
    158.             return unexpectedArgumentMessage();
    159.         } else
    160.             switch (errorCode) {
    161.                 case MISSING_STRING:
    162.                     return String.format("Could not find string parameter for -%c.", errorArgument);
    163.                 case OK:
    164.                     throw new Exception("TILT: Should not get here.");
    165.             }
    166.         return " ";
    167.     }
    169.     private String unexpectedArgumentMessage() {
    170.         StringBuffer message = new StringBuffer("Argument(s) -");
    171.         for (char c : unexpectedArguments) {
    172.             message.append(c);
    173.         }
    174.         message.append(" unexpected.");
    176.         return message.toString();
    177.     }
    179.     public boolean getBoolean(char arg) {
    180.         return falseIfNull(booleanArgs.get(arg));
    181.     }
    183.     private boolean falseIfNull(Boolean b) {
    184.         return b == null ? false : b;
    185.     }
    187.     public String getString(char arg) {
    188.         return blankIfNull(stringArgs.get(arg));
    189.     }
    191.     private String blankIfNull(String s) {
    192.         return s == null ? " " : s;
    193.     }
    195.     public boolean has(char arg) {
    196.         return argsFound.contains(arg);
    197.     }
    199.     public boolean isValid() {
    200.         return valid;
    201.     }
    202. }

    You can see that this is starting to get out of hand. It’s still not horrible, but the mess is certainly starting to grow. It’s a pile, but it’s not festering quite yet. It took the addition of the integer argument type to get this pile really fermenting and festering.

    So I Stopped I had at least two more argument types to add, and I could tell that they would make things much worse. If I bulldozed my way forward, I could probably get them to work, but I’d leave behind a mess that was too large to fix. If the structure of this code was ever going to be maintainable, now was the time to fix it.

    So I stopped adding features and started refactoring. Having just added the String and integer arguments, I knew that each argument type required new code in three major places. First, each argument type required some way to parse its schema element in order to select the HashMap for that type. Next, each argument type needed to be parsed in the command-line strings and converted to its true type. Finally, each argument type needed a getXXX method so that it could be returned to the caller as its true type.

    Many different types, all with similar methods—that sounds like a class to me. And so the ArgumentMarshaler concept was born.

    ARGS: THE ROUGH DRAFT To avoid this, I use the discipline of Test-Driven Development (TDD). One of the central doctrines of this approach is to keep the system running at all times. In other words, using TDD, I am not allowed to make a change to the system that breaks that system. Every change I make must keep the system working as it worked before.

    To achieve this, I need a suite of automated tests that I can run on a whim and that verifies that the behavior of the system is unchanged. For the Args class I had created a suite of unit and acceptance tests while I was building the festering pile. The unit tests were written in Java and administered by JUnit. The acceptance tests were written as wiki pages in FitNesse. I could run these tests any time I wanted, and if they passed, I was confident that the system was working as I specified.

    So I proceeded to make a large number of very tiny changes. Each change moved the structure of the system toward the ArgumentMarshaler concept. And yet each change kept the system working. The first change I made was to add the skeleton of the ArgumentMarshaller to the end of the festering pile (Listing 14-11).

    Listing 14-11 ArgumentMarshaller appended to Args.java

    1. private class ArgumentMarshaler {
    2.     private boolean booleanValue = false;
    5.     public void setBoolean(boolean value) {
    6.         booleanValue = value;
    7.     }
    9.     public boolean getBoolean() {
    10.         return booleanValue;
    11.     }
    12. }
    14. private class BooleanArgumentMarshaler extends ArgumentMarshaler {
    15. }
    17. private class StringArgumentMarshaler extends ArgumentMarshaler {
    18. }
    20. private class IntegerArgumentMarshaler extends ArgumentMarshaler {
    21. }

    Clearly, this wasn’t going to break anything. So then I made the simplest modification I could, one that would break as little as possible. I changed the HashMap for the Boolean arguments to take an ArgumentMarshaler.

    1. private Map<Character, ArgumentMarshaler> booleanArgs = new HashMap<Character, ArgumentMarshaler>();

    This broke a few statements, which I quickly fixed.

    1.    …
    2.      private void parseBooleanSchemaElement(char elementId) {
    3.        booleanArgs.put(elementId, new BooleanArgumentMarshaler());
    4.      }
    5.    ..
    6.      private void setBooleanArg(char argChar, boolean value) {
    7.        booleanArgs.get(argChar).setBoolean(value);
    8.      }
    9.    …
    10.      public boolean getBoolean(char arg) {
    11.        return falseIfNull(booleanArgs.get(arg).getBoolean());
    12.    }

    Notice how these changes are in exactly the areas that I mentioned before: the parse, set, and get for the argument type. Unfortunately, small as this change was, some of the tests started failing. If you look carefully at getBoolean, you’ll see that if you call it with ‘y,’ but there is no y argument, then booleanArgs.get(‘y’) will return null, and the function will throw a NullPointerException. The falseIfNull function had been used to protect against this, but the change I made caused that function to become irrelevant.

    Incrementalism demanded that I get this working quickly before making any other changes. Indeed, the fix was not too difficult. I just had to move the check for null. It was no longer the boolean being null that I needed to check; it was the ArgumentMarshaller.

    First, I removed the falseIfNull call in the getBoolean function. It was useless now, so I also eliminated the function itself. The tests still failed in the same way, so I was confident that I hadn’t introduced any new errors.

    1.    public boolean getBoolean(char arg) {
    2.      return booleanArgs.get(arg).getBoolean();
    3.    }

    Next, I split the function into two lines and put the ArgumentMarshaller into its own variable named argumentMarshaller. I didn’t care for the long variable name; it was badly redundant and cluttered up the function. So I shortened it to am [N5].

    1.    public boolean getBoolean(char arg) {
    2.      Args.ArgumentMarshaler am = booleanArgs.get(arg);

    And then I put in the null detection logic.

    1.    public boolean getBoolean(char arg) {
    2.      Args.ArgumentMarshaler am = booleanArgs.get(arg);
    3.      return am != null && am.getBoolean();
    4.    }

    STRING ARGUMENTS Addin_g String arguments was very similar to adding boolean arguments. I had to change the HashMap and get the parse, set, and get functions working. There shouldn’t be any surprises in what follows except, perhaps, that I seem to be putting all the marshalling implementation in the ArgumentMarshaller base class instead of distributing it to the derivatives.

    1.    private Map<Character, ArgumentMarshaler> stringArgs =
    2.        new HashMap<Character, ArgumentMarshaler>();
    3.   …
    4.    private void parseStringSchemaElement(char elementId) {
    5.      stringArgs.put(elementId, new StringArgumentMarshaler());
    6.    }
    7.   …
    8.    private void setStringArg(char argChar) throws ArgsException {
    9.     currentArgument++;
    10.     try {
    11.       stringArgs.get(argChar).setString(args[currentArgument]);
    12.     } catch (ArrayIndexOutOfBoundsException e) {
    13.       valid = false;
    14.       errorArgumentId = argChar;
    15.       errorCode = ErrorCode.MISSING_STRING;
    16.       throw new ArgsException();
    17.     }
    18.    }
    19.   …
    20.    public String getString(char arg) {
    21.      Args.ArgumentMarshaler am = stringArgs.get(arg);
    22.      return am == null ? “ ” : am.getString();
    23.    }
    24.   …
    25.   private class ArgumentMarshaler {
    26.     private boolean booleanValue = false;
    27.     private String stringValue;
    29.     public void setBoolean(boolean value) {
    30.       booleanValue = value;
    31.     }
    33.     public boolean getBoolean() {
    34.       return booleanValue;
    35.     }
    37.     public void setString(String s) {
    38.       stringValue = s;
    39.     }
    40.     public String getString() {
    41.       return stringValue == null ? “ ” : stringValue;
    42.     }
    43.   }

    Again, these changes were made one at a time and in such a way that the tests kept running, if not passing. When a test broke, I made sure to get it passing again before continuing with the next change.

    By now you should be able to see my intent. Once I get all the current marshalling behavior into the ArgumentMarshaler base class, I’m going to start pushing that behavior down into the derivatives. This will allow me to keep everything running while I gradually change the shape of this program.

    The obvious next step was to move the int argument functionality into the ArgumentMarshaler. Again, there weren’t any surprises.

    1.    private Map<Character, ArgumentMarshaler> intArgs =
    2.         new HashMap<Character, ArgumentMarshaler>();
    3.    …
    4.    private void parseIntegerSchemaElement(char elementId) {
    5.      intArgs.put(elementId, new IntegerArgumentMarshaler());
    6.    }
    7.   …
    9.    private void setIntArg(char argChar) throws ArgsException {
    10.      currentArgument++;
    11.      String parameter = null;
    12.      try {
    13.        parameter = args[currentArgument];
    14.        intArgs.get(argChar).setInteger(Integer.parseInt(parameter));
    15.      } catch (ArrayIndexOutOfBoundsException e) {
    16.        valid = false;
    17.        errorArgumentId = argChar;
    18.        errorCode = ErrorCode.MISSING_INTEGER;
    19.        throw new ArgsException();
    20.      } catch (NumberFormatException e) {
    21.        valid = false;
    22.        errorArgumentId = argChar;
    23.        errorParameter = parameter;
    24.        errorCode = ErrorCode.INVALID_INTEGER;
    25.        throw new ArgsException();
    26.      }
    27.    }
    28.  …
    29.    public int getInt(char arg) {
    30.      Args.ArgumentMarshaler am = intArgs.get(arg);
    31.      return am == null ? 0 : am.getInteger();
    32.    }
    33.   …
    34.    private class ArgumentMarshaler {
    35.      private boolean booleanValue = false;
    36.      private String stringValue;
    37.      private int integerValue;
    38.      public void setBoolean(boolean value) {
    39.        booleanValue = value;
    40.      }
    42.      public boolean getBoolean() {
    43.       return booleanValue;
    44.      }
    46.      public void setString(String s) {
    47.        stringValue = s;
    48.      }
    50.      public String getString() {
    51.        return stringValue == null ? “ ”: stringValue;
    52.      }
    53.      public void setInteger(int i) {
    54.        integerValue = i;
    55.      }
    56.      public int getInteger() {
    57.        return integerValue;
    58.      }
    59.    }

    With all the marshalling moved to the ArgumentMarshaler, I started pushing functionality into the derivatives. The first step was to move the setBoolean function into the BooleanArgumentMarshaller and make sure it got called correctly. So I created an abstract set method.

    1. private abstract class ArgumentMarshaler {
    2.     protected boolean booleanValue = false;
    3.     private String stringValue;
    4.     private int integerValue;
    6.     public void setBoolean(boolean value) {
    7.         booleanValue = value;
    8.     }
    10.     public boolean getBoolean() {
    11.         return booleanValue;
    12.     }
    14.     public void setString(String s) {
    15.         stringValue = s;
    16.     }
    18.     public String getString() {
    19.         return stringValue == null ? " " : stringValue;
    20.     }
    22.     public void setInteger(int i) {
    23.         integerValue = i;
    24.     }
    26.     public int getInteger() {
    27.         return integerValue;
    28.     }
    30.     public abstract void set(String s);
    31. }

    Then I implemented the set method in BooleanArgumentMarshaller.

    1.    private class BooleanArgumentMarshaler extends ArgumentMarshaler {
    2.      public void set(String s) {
    3.        booleanValue = true;
    4.      }
    5.    }

    And finally I replaced the call to setBoolean with a call to set.

    1.    private void setBooleanArg(char argChar, boolean value) {
    2.        booleanArgs.get(argChar) .set(“true”);
    3.       }

    The tests all still passed. Because this change caused set to be deployed to the Boolean-ArgumentMarshaler, I removed the setBoolean method from the ArgumentMarshaler base class.

    Notice that the abstract set function takes a String argument, but the implementation in the BooleanArgumentMarshaller does not use it. I put that argument in there because I knew that the StringArgumentMarshaller and IntegerArgumentMarshaller would use it.

    Next, I wanted to deploy the get method into BooleanArgumentMarshaler. Deploying get functions is always ugly because the return type has to be Object, and in this case needs to be cast to a Boolean.

    Just to get this to compile, I added the get function to the ArgumentMarshaler.

    1.    private abstract class ArgumentMarshaler {
    2.        …
    4.        public Object get() {
    5.          return null;
    6.        }
    7.    }

    This compiled and obviously failed the tests. Getting the tests working again was simply a matter of making get abstract and implementing it in BooleanAgumentMarshaler.

    1.    private abstract class ArgumentMarshaler {
    2.        protected boolean booleanValue = false;
    3.        …
    5.        public abstract Object get();
    6.      }
    8.      private class BooleanArgumentMarshaler extends ArgumentMarshaler {
    9.        public void set(String s) {
    10.          booleanValue = true;
    11.        }
    13.        public Object get() {
    14.          return booleanValue;
    15.        }
    16.    }

    Once again the tests passed. So both get and set deploy to the BooleanArgumentMarshaler! This allowed me to remove the old getBoolean function from ArgumentMarshaler, move the protected booleanValue variable down to BooleanArgumentMarshaler, and make it private.

    I did the same pattern of changes for Strings. I deployed both set and get, deleted the unused functions, and moved the variables.

    1. private void setStringArg(char argChar) throws ArgsException {
    2.     currentArgument++;
    3.     try {
    4.         stringArgs.get(argChar).set(args[currentArgument]);
    5.     } catch (ArrayIndexOutOfBoundsException e) {
    6.         valid = false;
    7.         errorArgumentId = argChar;
    8.         errorCode = ErrorCode.MISSING_STRING;
    9.         throw new ArgsException();
    10.     }
    11. }
    12. …
    14. public String getString(char arg) {
    15.     Args.ArgumentMarshaler am = stringArgs.get(arg);
    16.     return am == null ? " " : (String) am.get();
    17. }
    18. …
    19.      private abstract class ArgumentMarshaler {
    20.     private int integerValue;
    22.     public void setInteger(int i) {
    23.         integerValue = i;
    24.     }
    26.     public int getInteger() {
    27.         return integerValue;
    28.     }
    30.     public abstract void set(String s);
    32.     public abstract Object get();
    33. }
    35. private class BooleanArgumentMarshaler extends ArgumentMarshaler {
    36.     private boolean booleanValue = false;
    38.     public void set(String s) {
    39.         booleanValue = true;
    40.     }
    42.     public Object get() {
    43.         return booleanValue;
    44.     }
    45. }
    47. private class StringArgumentMarshaler extends ArgumentMarshaler {
    48.     private String stringValue = " ";
    50.     public void set(String s) {
    51.         stringValue = s;
    52.     }
    54.     public Object get() {
    55.         return stringValue;
    56.     }
    57. }
    59. private class IntegerArgumentMarshaler extends ArgumentMarshaler {
    61.     public void set(String s) {
    62.     }
    64.     public Object get() {
    65.         return null;
    66.     }
    67. }

    Finally, I repeated the process for integers. This was just a little more complicated because integers needed to be parsed, and the parse operation can throw an exception. But the result is better because the whole concept of NumberFormatException got buried in the IntegerArgumentMarshaler.

    1.    private boolean isIntArg(char argChar) {return intArgs.containsKey(argChar);}
    3.      private void setIntArg(char argChar) throws ArgsException {
    4.        currentArgument++;
    5.        String parameter = null;
    6.        try {
    7.          parameter = args[currentArgument];
    8.          intArgs.get(argChar).set(parameter);
    9.        } catch (ArrayIndexOutOfBoundsException e) {
    10.          valid = false;
    11.          errorArgumentId = argChar;
    12.          errorCode = ErrorCode.MISSING_INTEGER;
    13.          throw new ArgsException();
    14.        } catch (ArgsException e) {
    15.          valid = false;
    16.          errorArgumentId = argChar;
    17.          errorParameter = parameter;
    18.          errorCode = ErrorCode.INVALID_INTEGER;
    19.          throw e;
    20.        }
    21.      }
    22.    …
    23.      private void setBooleanArg(char argChar) {
    24.        try {
    25.                  booleanArgs.get(argChar).set(“true”);
    26.        } catch (ArgsException e) {
    27.        }
    28.      }
    29.    …
    30.      public int getInt(char arg) {
    31.        Args.ArgumentMarshaler am = intArgs.get(arg);
    32.        return am == null ? 0 : (Integer) am.get();
    33.      }
    34.    …
    35.      private abstract class ArgumentMarshaler {
    36.        public abstract void set(String s) throws ArgsException;
    37.        public abstract Object get();
    38.      }
    39.    …
    40.      private class IntegerArgumentMarshaler extends ArgumentMarshaler {
    41.        private int intValue = 0;
    43.        public void set(String s) throws ArgsException {
    44.          try {
    45.            intValue = Integer.parseInt(s);
    46.          } catch (NumberFormatException e) {
    47.            throw new ArgsException();
    48.          }
    49.        }
    51.        public Object get() {
    52.          return intValue;
    53.        }
    54.      }

    Of course, the tests continued to pass. Next, I got rid of the three different maps up at the top of the algorithm. This made the whole system much more generic. However, I couldn’t get rid of them just by deleting them because that would break the system. Instead, I added a new Map for the ArgumentMarshaler and then one by one changed the methods to use it instead of the three original maps.

    1. public class Args {
    2.    …
    3.     private Map<Character, ArgumentMarshaler> booleanArgs =
    4.             new HashMap<Character, ArgumentMarshaler>();
    5.     private Map<Character, ArgumentMarshaler> stringArgs =
    6.             new HashMap<Character, ArgumentMarshaler>();
    7.     private Map<Character, ArgumentMarshaler> intArgs =
    8.             new HashMap<Character, ArgumentMarshaler>();
    9.     private Map<Character, ArgumentMarshaler> marshalers =
    10.             new HashMap<Character, ArgumentMarshaler>();
    11.    …
    13.     private void parseBooleanSchemaElement(char elementId) {
    14.         ArgumentMarshaler m = new BooleanArgumentMarshaler();
    15.         booleanArgs.put(elementId, m);
    16.         marshalers.put(elementId, m);
    17.     }
    19.     private void parseIntegerSchemaElement(char elementId) {
    20.         ArgumentMarshaler m = new IntegerArgumentMarshaler();
    21.         intArgs.put(elementId, m);
    22.         marshalers.put(elementId, m);
    23.     }
    25.     private void parseStringSchemaElement(char elementId) {
    26.         ArgumentMarshaler m = new StringArgumentMarshaler();
    27.         stringArgs.put(elementId, m);
    28.         marshalers.put(elementId, m);
    29.     }
    30. }

    Of course the tests all still passed. Next, I changed isBooleanArg from this:

    1.    private boolean isBooleanArg(char argChar) {
    2.      return booleanArgs.containsKey(argChar);
    3.    }

    to this:

    1.    private boolean isBooleanArg(char argChar) {
    2.      ArgumentMarshaler m = marshalers.get(argChar);
    3.      return m instanceof BooleanArgumentMarshaler;
    4.    }

    The tests still passed. So I made the same change to isIntArg and isStringArg.

    1. private boolean isIntArg(char argChar) {
    2.     ArgumentMarshaler m = marshalers.get(argChar);
    3.     return m instanceof IntegerArgumentMarshaler;
    4. }
    6. private boolean isStringArg(char argChar) {
    7.     ArgumentMarshaler m = marshalers.get(argChar);
    8.     return m instanceof StringArgumentMarshaler;
    9. }

    The tests still passed. So I eliminated all the duplicate calls to marshalers.get as follows:

    1. private boolean setArgument(char argChar) throws ArgsException {
    2.     ArgumentMarshaler m = marshalers.get(argChar);
    3.     if (isBooleanArg(m))
    4.         setBooleanArg(argChar);
    5.     else if (isStringArg(m))
    6.         setStringArg(argChar);
    7.     else if (isIntArg(m))
    8.         setIntArg(argChar);
    9.     else
    10.         return false;
    12.     return true;
    13. }
    15. private boolean isIntArg(ArgumentMarshaler m) {
    16.     return m instanceof IntegerArgumentMarshaler;
    17. }
    19. private boolean isStringArg(ArgumentMarshaler m) {
    20.     return m instanceof StringArgumentMarshaler;
    21. }
    23. private boolean isBooleanArg(ArgumentMarshaler m) {
    24.     return m instanceof BooleanArgumentMarshaler;
    25. }

    This left no good reason for the three isxxxArg methods. So I inlined them:

    1. private boolean setArgument(char argChar) throws ArgsException {
    2.     ArgumentMarshaler m = marshalers.get(argChar);
    3.     if (m instanceof BooleanArgumentMarshaler)
    4.         setBooleanArg(argChar);
    5.     else if (m instanceof StringArgumentMarshaler)
    6.         setStringArg(argChar);
    7.     else if (m instanceof IntegerArgumentMarshaler)
    8.         setIntArg(argChar);
    9.     else
    10.         return false;
    12.     return true;
    13. }

    Next, I started using the marshalers map in the set functions, breaking the use of the other three maps. I started with the booleans.

    1. public class Args {
    2.     private boolean setArgument(char argChar) throws ArgsException {
    3.         ArgumentMarshaler m = marshalers.get(argChar);
    4.         if (m instanceof BooleanArgumentMarshaler)
    5.             setBooleanArg(m);
    6.         else if (m instanceof StringArgumentMarshaler)
    7.             setStringArg(argChar);
    8.         else if (m instanceof IntegerArgumentMarshaler)
    9.             setIntArg(argChar);
    10.         else
    11.             return false;
    12.         return true;
    13.     }
    14.    …
    16.     private void setBooleanArg(ArgumentMarshaler m) {
    17.         try {
    18.             m.set("true"); // was: booleanArgs.get(argChar).set("true");
    19.         } catch (ArgsException e) {
    20.         }
    21.     }
    22. }

    The tests still passed, so I did the same with Strings and Integers. This allowed me to integrate some of the ugly exception management code into the setArgument function.

    1. private boolean setArgument(char argChar) throws ArgsException {
    2.     ArgumentMarshaler m = marshalers.get(argChar);
    3.     try {
    4.         if (m instanceof BooleanArgumentMarshaler)
    5.             setBooleanArg(m);
    6.         else if (m instanceof StringArgumentMarshaler)
    7.             setStringArg(m);
    8.         else if (m instanceof IntegerArgumentMarshaler)
    9.             setIntArg(m);
    10.         else
    11.             return false;
    12.     } catch (ArgsException e) {
    13.         valid = false;
    14.         errorArgumentId = argChar;
    15.         throw e;
    16.     }
    17.     return true;
    18. }
    20. private void setIntArg(ArgumentMarshaler m) throws ArgsException {
    21.     currentArgument++;
    22.     String parameter = null;
    23.     try {
    24.         parameter = args[currentArgument];
    25.         m.set(parameter);
    26.     } catch (ArrayIndexOutOfBoundsException e) {
    27.         errorCode = ErrorCode.MISSING_INTEGER;
    28.         throw new ArgsException();
    29.     } catch (ArgsException e) {
    30.         errorParameter = parameter;
    31.         errorCode = ErrorCode.INVALID_INTEGER;
    32.         throw e;
    33.     }
    34. }
    36. private void setStringArg(ArgumentMarshaler m) throws ArgsException {
    37.     currentArgument++;
    38.     try {
    39.         m.set(args[currentArgument]);
    40.     } catch (ArrayIndexOutOfBoundsException e) {
    41.         errorCode = ErrorCode.MISSING_STRING;
    42.         throw new ArgsException();
    43.     }
    44. }

    I was close to being able to remove the three old maps. First, I needed to change the getBoolean function from this:

    1. public boolean getBoolean(char arg) {
    2.     Args.ArgumentMarshaler am = booleanArgs.get(arg);
    3.     return am != null && (Boolean) am.get();
    4. }

    to this:

    1. public boolean getBoolean(char arg) {
    2.     Args.ArgumentMarshaler am = marshalers.get(arg);
    3.     boolean b = false;
    4.     try {
    5.         b = am != null && (Boolean) am.get();
    6.     } catch (ClassCastException e) {
    8.         b = false;
    9.     }
    10.     return b;
    11. }

    This last change might have been a surprise. Why did I suddenly decide to deal with the ClassCastException? The reason is that I have a set of unit tests and a separate set of acceptance tests written in FitNesse. It turns out that the FitNesse tests made sure that if you called getBoolean on a nonboolean argument, you got a false. The unit tests did not. Up to this point I had only been running the unit tests.2

    This last change allowed me to pull out another use of the boolean map:

    1. private void parseBooleanSchemaElement(char elementId) {
    2.     ArgumentMarshaler m = new BooleanArgumentMarshaler();
    3.     booleanArgs.put(elementId, m);
    4.     marshalers.put(elementId, m);
    5. }

    And now we can delete the boolean map.

    1. public class Args {
    2.    …
    3.     private Map<Character, ArgumentMarshaler> booleanArgs
    4.             = new HashMap<Character, ArgumentMarshaler>();
    5.     private Map<Character, ArgumentMarshaler> stringArgs =
    6.             new HashMap<Character, ArgumentMarshaler>();
    7.     private Map<Character, ArgumentMarshaler> intArgs =
    8.             new HashMap<Character, ArgumentMarshaler>();
    9.     private Map<Character, ArgumentMarshaler> marshalers =
    10.             new HashMap<Character, ArgumentMarshaler>();
    11.    …
    12. }
    1.    private void parseBooleanSchemaElement(char elementId) {
    2.      marshalers.put(elementId, new BooleanArgumentMarshaler());
    3.    }
    4.    private void parseIntegerSchemaElement(char elementId) {
    5.      marshalers.put(elementId, new IntegerArgumentMarshaler());
    6.    }
    8.    private void parseStringSchemaElement(char elementId) {
    9.      marshalers.put(elementId, new StringArgumentMarshaler());
    10.    }
    11.   …
    12.    public String getString(char arg) {
    13.      Args.ArgumentMarshaler am = marshalers.get(arg);
    14.      try {
    15.        return am == null ? “ ” : (String) am.get();
    16.      } catch (ClassCastException e) {
    17.        return “ ”;
    18.      }
    19.    }
    21.    public int getInt(char arg) {
    22.      Args.ArgumentMarshaler am = marshalers.get(arg);
    23.      try {
    24.        return am == null ? 0 : (Integer) am.get();
    25.      } catch (Exception e) {
    26.        return 0;
    27.      }
    28.    }
    29.  …
    30.  public class Args {
    31.  …
    32.    private Map<Character, ArgumentMarshaler> stringArgs =
    33.    new HashMap<Character, ArgumentMarshaler>();
    34.    private Map<Character, ArgumentMarshaler> intArgs =
    35.    new HashMap<Character, ArgumentMarshaler>();
    36.    private Map<Character, ArgumentMarshaler> marshalers =
    37.    new HashMap<Character, ArgumentMarshaler>();
    38.   …

    Next, I inlined the three parse methods because they didn’t do much anymore:

    1. private void parseSchemaElement(String element) throws ParseException {
    2.     char elementId = element.charAt(0);
    3.     String elementTail = element.substring(1);
    4.     validateSchemaElementId(elementId);
    5.     if (isBooleanSchemaElement(elementTail))
    6.         marshalers.put(elementId, new BooleanArgumentMarshaler());
    7.     else if (isStringSchemaElement(elementTail))
    8.         marshalers.put(elementId, new StringArgumentMarshaler());
    9.     else if (isIntegerSchemaElement(elementTail)) {
    10.         marshalers.put(elementId, new IntegerArgumentMarshaler());
    11.     } else {
    12.         throw new ParseException(String.format(
    13.                 "Argument: %c has invalid format: %s.", elementId, elementTail), 0);
    14.     }
    15. }

    Okay, so now let’s look at the whole picture again. Listing 14-12 shows the current form of the Args class.

    Listing 14-12 Args.java (After first refactoring)

    1. package com.objectmentor.utilities.getopts;
    4. import java.text.ParseException;
    5. import java.util.*;
    7. public class Args {
    8.     private String schema;
    9.     private String[] args;
    10.     private boolean valid = true;
    11.     private Set<Character> unexpectedArguments = new TreeSet<Character>();
    12.     private Map<Character, ArgumentMarshaler> marshalers =
    13.             new HashMap<Character, ArgumentMarshaler>();
    14.     private Set<Character> argsFound = new HashSet<Character>();
    15.     private int currentArgument;
    16.     private char errorArgumentId = '\0';
    17.     private String errorParameter = "TILT";
    18.     private ErrorCode errorCode = ErrorCode.OK;
    21.     private enum ErrorCode {
    22.         OK, MISSING_STRING, MISSING_INTEGER, INVALID_INTEGER,
    23.         UNEXPECTED_ARGUMENT
    24.     }
    26.     public Args(String schema, String[] args) throws ParseException {
    27.         this.schema = schema;
    28.         this.args = args;
    29.         valid = parse();
    30.     }
    32.     private boolean parse() throws ParseException {
    33.         if (schema.length() == 0 && args.length == 0)
    34.             return true;
    35.         parseSchema();
    36.         try {
    37.             parseArguments();
    38.         } catch (ArgsException e) {
    39.         }
    40.         return valid;
    41.     }
    43.     private boolean parseSchema() throws ParseException {
    44.         for (String element : schema.split(",")) {
    45.             if (element.length() > 0) {
    46.                 String trimmedElement = element.trim();
    47.                 parseSchemaElement(trimmedElement);
    48.             }
    49.         }
    50.         return true;
    51.     }
    53.     private void parseSchemaElement(String element) throws ParseException {
    54.         char elementId = element.charAt(0);
    55.         String elementTail = element.substring(1);
    56.         validateSchemaElementId(elementId);
    57.         if (isBooleanSchemaElement(elementTail))
    58.             marshalers.put(elementId, new BooleanArgumentMarshaler());
    59.         else if (isStringSchemaElement(elementTail))
    60.             marshalers.put(elementId, new StringArgumentMarshaler());
    61.         else if (isIntegerSchemaElement(elementTail)) {
    62.             marshalers.put(elementId, new IntegerArgumentMarshaler());
    63.         } else {
    64.             throw new ParseException(String.format(
    65.                     "Argument: %c has invalid format: %s.", elementId, elementTail), 0);
    66.         }
    67.     }
    69.     private void validateSchemaElementId(char elementId) throws ParseException {
    70.         if (!Character.isLetter(elementId)) {
    71.             throw new ParseException(
    72.                     "Bad character:" + elementId + "in Args format: " + schema, 0);
    73.         }
    74.     }
    76.     private boolean isStringSchemaElement(String elementTail) {
    77.         return elementTail.equals("*");
    78.     }
    80.     private boolean isBooleanSchemaElement(String elementTail) {
    81.         return elementTail.length() == 0;
    82.     }
    84.     private boolean isIntegerSchemaElement(String elementTail) {
    85.         return elementTail.equals("-");
    86.     }
    88.     private boolean parseArguments() throws ArgsException {
    89.         for (currentArgument = 0; currentArgument < args.length; currentArgument++) {
    90.             String arg = args[currentArgument];
    91.             parseArgument(arg);
    92.         }
    93.         return true;
    94.     }
    96.     private void parseArgument(String arg) throws ArgsException {
    97.         if (arg.startsWith("-"))
    98.             parseElements(arg);
    99.     }
    101.     private void parseElements(String arg) throws ArgsException {
    102.         for (int i = 1; i < arg.length(); i++)
    103.             parseElement(arg.charAt(i));
    104.     }
    106.     private void parseElement(char argChar) throws ArgsException {
    107.         if (setArgument(argChar))
    108.             argsFound.add(argChar);
    109.         else {
    110.             unexpectedArguments.add(argChar);
    111.             errorCode = ErrorCode.UNEXPECTED_ARGUMENT;
    112.             valid = false;
    113.         }
    114.     }
    116.     private boolean setArgument(char argChar) throws ArgsException {
    117.         ArgumentMarshaler m = marshalers.get(argChar);
    118.         try {
    119.             if (m instanceof BooleanArgumentMarshaler)
    120.                 setBooleanArg(m);
    121.             else if (m instanceof StringArgumentMarshaler)
    122.                 setStringArg(m);
    123.             else if (m instanceof IntegerArgumentMarshaler)
    124.                 setIntArg(m);
    125.             else
    126.                 return false;
    127.         } catch (ArgsException e) {
    128.             valid = false;
    129.             errorArgumentId = argChar;
    130.             throw e;
    131.         }
    132.         return true;
    133.     }
    135.     private void setIntArg(ArgumentMarshaler m) throws ArgsException {
    136.         currentArgument++;
    137.         String parameter = null;
    138.         try {
    139.             parameter = args[currentArgument];
    140.             m.set(parameter);
    141.         } catch (ArrayIndexOutOfBoundsException e) {
    142.             errorCode = ErrorCode.MISSING_INTEGER;
    143.             throw new ArgsException();
    144.         } catch (ArgsException e) {
    145.             errorParameter = parameter;
    146.             errorCode = ErrorCode.INVALID_INTEGER;
    147.             throw e;
    148.         }
    149.     }
    151.     private void setStringArg(ArgumentMarshaler m) throws ArgsException {
    152.         currentArgument++;
    153.         try {
    154.             m.set(args[currentArgument]);
    155.         } catch (ArrayIndexOutOfBoundsException e) {
    156.             errorCode = ErrorCode.MISSING_STRING;
    157.             throw new ArgsException();
    158.         }
    159.     }
    161.     private void setBooleanArg(ArgumentMarshaler m) {
    162.         try {
    163.             m.set("true");
    164.         } catch (ArgsException e) {
    165.         }
    166.     }
    168.     public int cardinality() {
    169.         return argsFound.size();
    170.     }
    172.     public String usage() {
    173.         if (schema.length() > 0)
    174.             return "-[" + schema + "]";
    175.         else
    176.             return " ";
    177.     }
    179.     public String errorMessage() throws Exception {
    180.         switch (errorCode) {
    181.             case OK:
    182.                 throw new Exception("TILT: Should not get here.");
    183.             case UNEXPECTED_ARGUMENT:
    184.                 return unexpectedArgumentMessage();
    185.             case MISSING_STRING:
    186.                 return String.format("Could not find string parameter for -%c.",
    187.                         errorArgumentId);
    188.             case INVALID_INTEGER:
    189.                 return String.format("Argument -%c expects an integer but was '%s'.",
    190.                         errorArgumentId, errorParameter);
    191.             case MISSING_INTEGER:
    192.                 return String.format("Could not find integer parameter for -%c.",
    193.                         errorArgumentId);
    194.         }
    195.         return " ";
    196.     }
    198.     private String unexpectedArgumentMessage() {
    199.         StringBuffer message = new StringBuffer("Argument(s) -");
    200.         for (char c : unexpectedArguments) {
    201.             message.append(c);
    202.         }
    203.         message.append(" unexpected.");
    205.         return message.toString();
    206.     }
    208.     public boolean getBoolean(char arg) {
    209.         Args.ArgumentMarshaler am = marshalers.get(arg);
    210.         boolean b = false;
    211.         try {
    212.             b = am != null && (Boolean) am.get();
    213.         } catch (ClassCastException e) {
    214.             b = false;
    215.         }
    216.         return b;
    217.     }
    219.     public String getString(char arg) {
    220.         Args.ArgumentMarshaler am = marshalers.get(arg);
    221.         try {
    222.             return am == null ? " " : (String) am.get();
    223.         } catch (ClassCastException e) {
    224.             return " ";
    225.         }
    226.     }
    228.     public int getInt(char arg) {
    229.         Args.ArgumentMarshaler am = marshalers.get(arg);
    230.         try {
    231.             return am == null ? 0 : (Integer) am.get();
    232.         } catch (Exception e) {
    233.             return 0;
    234.         }
    235.     }
    237.     public boolean has(char arg) {
    238.         return argsFound.contains(arg);
    239.     }
    241.     public boolean isValid() {
    242.         return valid;
    243.     }
    245.     private class ArgsException extends Exception {
    246.     }
    248.     private abstract class ArgumentMarshaler {
    249.         public abstract void set(String s) throws ArgsException;
    251.         public abstract Object get();
    252.     }
    254.     private class BooleanArgumentMarshaler extends ArgumentMarshaler {
    255.         private boolean booleanValue = false;
    258.         public void set(String s) {
    259.             booleanValue = true;
    260.         }
    262.         public Object get() {
    263.             return booleanValue;
    264.         }
    265.     }
    267.     private class StringArgumentMarshaler extends ArgumentMarshaler {
    268.         private String stringValue = " ";
    270.         public void set(String s) {
    271.             stringValue = s;
    272.         }
    274.         public Object get() {
    275.             return stringValue;
    276.         }
    277.     }
    279.     private class IntegerArgumentMarshaler extends ArgumentMarshaler {
    280.         private int intValue = 0;
    282.         public void set(String s) throws ArgsException {
    283.             try {
    284.                 intValue = Integer.parseInt(s);
    285.             } catch (NumberFormatException e) {
    286.                 throw new ArgsException();
    287.             }
    288.         }
    290.         public Object get() {
    291.             return intValue;
    292.         }
    293.     }
    294. }

    After all that work, this is a bit disappointing. The structure is a bit better, but we still have all those variables up at the top; there’s still a horrible type-case in setArgument; and all those set functions are really ugly. Not to mention all the error processing. We still have a lot of work ahead of us.

    I’d really like to get rid of that type-case up in setArgument [G23]. What I’d like in setArgument is a single call to ArgumentMarshaler.set. This means I need to push setIntArg, setStringArg, and setBooleanArg down into the appropriate ArgumentMarshaler derivatives. But there is a problem.

    If you look closely at setIntArg, you’ll notice that it uses two instance variables: args and currentArg. To move setIntArg down into BooleanArgumentMarshaler, I’ll have to pass both args and currentArgs as function arguments. That’s dirty [F1]. I’d rather pass one argument instead of two. Fortunately, there is a simple solution. We can convert the args array into a list and pass an Iterator down to the set functions. The following took me ten steps, passing all the tests after each. But I’ll just show you the result. You should be able to figure out what most of the tiny little steps were.

    1. public class Args {
    2.     private String schema;
    3.     private String[] args;
    4.     private boolean valid = true;
    5.     private Set<Character> unexpectedArguments = new TreeSet<Character>();
    6.     private Map<Character, ArgumentMarshaler> marshalers =
    7.             new HashMap<Character, ArgumentMarshaler>();
    8.     private Set<Character> argsFound = new HashSet<Character>();
    9.     private Iterator<String> currentArgument;
    10.     private char errorArgumentId = '\0';
    11.     private String errorParameter = "TILT";
    12.     private ErrorCode errorCode = ErrorCode.OK;
    13.     private List<String> argsList;
    15.     private enum ErrorCode {
    16.         OK, MISSING_STRING, MISSING_INTEGER, INVALID_INTEGER,
    17.         UNEXPECTED_ARGUMENT
    18.     }
    20.     public Args(String schema, String[] args) throws ParseException {
    21.         this.schema = schema;
    22.         argsList = Arrays.asList(args);
    23.         valid = parse();
    24.     }
    26.     private boolean parse() throws ParseException {
    27.         if (schema.length() == 0 && argsList.size() == 0)
    28.             return true;
    29.         parseSchema();
    30.         try {
    31.             parseArguments();
    32.         } catch (ArgsException e) {
    33.         }
    34.         return valid;
    35.     }
    36. }
    38. ---
    40. private boolean parseArguments() throws ArgsException {
    41.     for (currentArgument = argsList.iterator(); currentArgument.hasNext(); ) {
    42.         String arg = currentArgument.next();
    43.         parseArgument(arg);
    44.     }
    46.     return true;
    47. }
    49. ---
    51. private void setIntArg(ArgumentMarshaler m) throws ArgsException {
    52.     String parameter = null;
    53.     try {
    54.         parameter = currentArgument.next();
    55.         m.set(parameter);
    56.     } catch (NoSuchElementException e) {
    57.         errorCode = ErrorCode.MISSING_INTEGER;
    58.         throw new ArgsException();
    59.     } catch (ArgsException e) {
    60.         errorParameter = parameter;
    61.         errorCode = ErrorCode.INVALID_INTEGER;
    62.         throw e;
    63.     }
    65. private void setStringArg(ArgumentMarshaler m) throws ArgsException {
    66.     try {
    67.         m.set(currentArgument.next());
    68.     } catch (NoSuchElementException e) {
    69.         errorCode = ErrorCode.MISSING_STRING;
    70.         throw new ArgsException();
    71.     }
    72. }

    These were simple changes that kept all the tests passing. Now we can start moving the set functions down into the appropriate derivatives. First, I need to make the following change in setArgument:

    This change is important because we want to completely eliminate the if-else chain. Therefore, we needed to get the error condition out of it.

    Now we can start to move the set functions. The setBooleanArg function is trivial, so we’ll prepare that one first. Our goal is to change the setBooleanArg function to simply forward to the BooleanArgumentMarshaler.

    1. private boolean setArgument(char argChar) throws ArgsException {
    2.     ArgumentMarshaler m = marshalers.get(argChar);
    3.     if (m == null)
    4.         return false;
    5.     try {
    6.         if (m instanceof BooleanArgumentMarshaler)
    7.             setBooleanArg(m, currentArgument);
    8.         else if (m instanceof StringArgumentMarshaler)
    9.             setStringArg(m);
    10.         else if (m instanceof IntegerArgumentMarshaler)
    11.             setIntArg(m);
    12.     } catch (ArgsException e) {
    13.         valid = false;
    14.         errorArgumentId = argChar;
    15.         throw e;
    16.     }
    17.     return true;
    18. }
    20. ---
    22. private void setBooleanArg(ArgumentMarshaler m, Iterator<String> currentArgument)
    23.         throws ArgsException {
    24.     try {
    25.         m.set("true");
    26.     } catch (ArgsException e) {
    27.     }
    28. }

    Didn’t we just put that exception processing in? Putting things in so you can take them out again is pretty common in refactoring. The smallness of the steps and the need to keep the tests running means that you move things around a lot. Refactoring is a lot like solving a Rubik’s cube. There are lots of little steps required to achieve a large goal. Each step enables the next.

    Why did we pass that iterator when setBooleanArg certainly doesn’t need it? Because setIntArg and setStringArg will! And because I want to deploy all three of these functions through an abstract method in ArgumentMarshaller, I need to pass it to setBooleanArg.

    So now setBooleanArg is useless. If there were a set function in ArgumentMarshaler, we could call it directly. So it’s time to make that function! The first step is to add the new abstract method to ArgumentMarshaler.

    1. private abstract class ArgumentMarshaler {
    2.     public abstract void set(Iterator<String> currentArgument)
    3.             throws ArgsException;
    5.     public abstract void set(String s) throws ArgsException;
    7.     public abstract Object get();
    8. }

    Of course this breaks all the derivatives. So let’s implement the new method in each.

    1. private class BooleanArgumentMarshaler extends ArgumentMarshaler {
    2.     private boolean booleanValue = false;
    4.     public void set(Iterator<String> currentArgument) throws ArgsException {
    5.         booleanValue = true;
    6.     }
    8.     public void set(String s) {
    9.         booleanValue = true;
    10.     }
    12.     public Object get() {
    13.         return booleanValue;
    14.     }
    15. }
    17. private class StringArgumentMarshaler extends ArgumentMarshaler {
    18.     private String stringValue = "";
    20.     public void set(Iterator<String> currentArgument) throws ArgsException {
    21.     }
    23.     public void set(String s) {
    24.         stringValue = s;
    25.     }
    27.     public Object get() {
    28.         return stringValue;
    29.     }
    30. }
    32. private class IntegerArgumentMarshaler extends ArgumentMarshaler {
    33.     private int intValue = 0;
    35.     public void set(Iterator<String> currentArgument) throws ArgsException {
    36.     }
    38.     public void set(String s) throws ArgsException {
    39.         try {
    40.             intValue = Integer.parseInt(s);
    41.         } catch (NumberFormatException e) {
    42.             throw new ArgsException();
    43.         }
    44.     }
    46.     public Object get() {
    47.         return intValue;
    48.     }
    49. }

    And now we can eliminate setBooleanArg!

    1. private boolean setArgument(char argChar) throws ArgsException {
    2.     ArgumentMarshaler m = marshalers.get(argChar);
    3.     if (m == null)
    4.         return false;
    5.     try {
    6.         if (m instanceof BooleanArgumentMarshaler)
    7.             m.set(currentArgument);
    8.         else if (m instanceof StringArgumentMarshaler)
    9.             setStringArg(m);
    10.         else if (m instanceof IntegerArgumentMarshaler)
    11.             setIntArg(m);
    13.     } catch (ArgsException e) {
    14.         valid = false;
    15.         errorArgumentId = argChar;
    16.         throw e;
    17.     }
    18.     return true;
    19. }

    The tests all pass, and the set function is deploying to BooleanArgumentMarshaler! Now we can do the same for Strings and Integers.

    1. private boolean setArgument(char argChar) throws ArgsException {
    2.     ArgumentMarshaler m = marshalers.get(argChar);
    3.     if (m == null)
    4.         return false;
    5.     try {
    6.         if (m instanceof BooleanArgumentMarshaler)
    7.             m.set(currentArgument);
    8.         else if (m instanceof StringArgumentMarshaler)
    9.             m.set(currentArgument);
    10.         else if (m instanceof IntegerArgumentMarshaler)
    11.             m.set(currentArgument);
    12.     } catch (ArgsException e) {
    13.         valid = false;
    14.         errorArgumentId = argChar;
    15.         throw e;
    16.     }
    17.     return true;
    18. }
    20. ---
    22. private class StringArgumentMarshaler extends ArgumentMarshaler {
    23.     private String stringValue = "";
    25.     public void set(Iterator<String> currentArgument) throws ArgsException {
    26.         try {
    27.             stringValue = currentArgument.next();
    28.         } catch (NoSuchElementException e) {
    29.             errorCode = ErrorCode.MISSING_STRING;
    30.             throw new ArgsException();
    31.         }
    32.     }
    34.     public void set(String s) {
    35.     }
    37.     public Object get() {
    38.         return stringValue;
    39.     }
    40. }
    42. private class IntegerArgumentMarshaler extends ArgumentMarshaler {
    43.     private int intValue = 0;
    45.     public void set(Iterator<String> currentArgument) throws ArgsException {
    46.         String parameter = null;
    47.         try {
    48.             parameter = currentArgument.next();
    49.             set(parameter);
    50.         } catch (NoSuchElementException e) {
    51.             errorCode = ErrorCode.MISSING_INTEGER;
    52.             throw new ArgsException();
    53.         } catch (ArgsException e) {
    54.             errorParameter = parameter;
    55.             errorCode = ErrorCode.INVALID_INTEGER;
    56.             throw e;
    57.         }
    58.     }
    60.     public void set(String s) throws ArgsException {
    61.         try {
    62.             intValue = Integer.parseInt(s);
    63.         } catch (NumberFormatException e) {
    64.             throw new ArgsException();
    65.         }
    66.     }
    68.     public Object get() {
    69.         return intValue;
    70.     }
    71. }

    And so the coup de grace: The type-case can be removed! Touche!

    1. private boolean setArgument(char argChar) throws ArgsException {
    2.     ArgumentMarshaler m = marshalers.get(argChar);
    3.     if (m == null)
    4.         return false;
    5.     try {
    6.         m.set(currentArgument);
    7.         return true;
    8.     } catch (ArgsException e) {
    9.         valid = false;
    10.         errorArgumentId = argChar;
    11.         throw e;
    12.     }
    13. }

    Now we can get rid of some crufty functions in IntegerArgumentMarshaler and clean it up a bit.

    1. private class IntegerArgumentMarshaler extends ArgumentMarshaler {
    2.     private int intValue = 0
    4.     public void set(Iterator<String> currentArgument) throws ArgsException {
    5.         String parameter = null;
    6.         try {
    7.             parameter = currentArgument.next();
    8.             intValue = Integer.parseInt(parameter);
    9.         } catch (NoSuchElementException e) {
    10.             errorCode = ErrorCode.MISSING_INTEGER;
    11.             throw new ArgsException();
    12.         } catch (NumberFormatException e) {
    13.             errorParameter = parameter;
    14.             errorCode = ErrorCode.INVALID_INTEGER;
    15.             throw new ArgsException();
    16.         }
    17.     }
    19.     public Object get() {
    20.         return intValue;
    21.     }
    22. }

    We can also turn ArgumentMarshaler into an interface.

    1. private interface ArgumentMarshaler {
    2.     void set(Iterator<String> currentArgument) throws ArgsException;
    4.     Object get();
    5. }

    So now let’s see how easy it is to add a new argument type to our structure. It should require very few changes, and those changes should be isolated. First, we begin by adding a new test case to check that the double argument works correctly.

    1. public void testSimpleDoublePresent() throws Exception {
    2.     Args args = new Args("x##", new String[]{"-x", "42.3"});
    3.     assertTrue(args.isValid());
    4.     assertEquals(1, args.cardinality());
    5.     assertTrue(args.has('x'));
    6.     assertEquals(42.3, args.getDouble('x'), .001);
    7. }

    Now we clean up the schema parsing code and add the ## detection for the double argument type.

    1. private void parseSchemaElement(String element) throws ParseException {
    2.     char elementId = element.charAt(0);
    3.     String elementTail = element.substring(1);
    4.     validateSchemaElementId(elementId);
    5.     if (elementTail.length() == 0)
    6.         marshalers.put(elementId, new BooleanArgumentMarshaler());
    7.     else if (elementTail.equals("*"))
    8.         marshalers.put(elementId, new StringArgumentMarshaler());
    9.     else if (elementTail.equals("#"))
    10.         marshalers.put(elementId, new IntegerArgumentMarshaler());
    11.     else if (elementTail.equals("##"))
    12.         marshalers.put(elementId, new DoubleArgumentMarshaler());
    13.     else
    14.         throw new ParseException(String.format(
    15.                 "Argument: %c has invalid format: %s.", elementId, elementTail), 0);
    16. }

    Next, we write the DoubleArgumentMarshaler class.

    1. private class DoubleArgumentMarshaler implements ArgumentMarshaler {
    2.     private double doubleValue = 0;
    4.     public void set(Iterator<String> currentArgument) throws ArgsException {
    5.         String parameter = null;
    6.         try {
    7.             parameter = currentArgument.next();
    8.             doubleValue = Double.parseDouble(parameter);
    9.         } catch (NoSuchElementException e) {
    10.             errorCode = ErrorCode.MISSING_DOUBLE;
    11.             throw new ArgsException();
    12.         } catch (NumberFormatException e) {
    13.             errorParameter = parameter;
    14.             errorCode = ErrorCode.INVALID_DOUBLE;
    15.             throw new ArgsException();
    16.         }
    17.     }
    19.     public Object get() {
    20.         return doubleValue;
    21.     }
    22. }

    This forces us to add a new ErrorCode.

    1. private enum ErrorCode {
    2.     OK, MISSING_STRING, MISSING_INTEGER, INVALID_INTEGER, UNEXPECTED_ARGUMENT,
    3.     MISSING_DOUBLE, INVALID_DOUBLE
    4. }

    And we need a getDouble function.

    1. public double getDouble(char arg) {
    2.     Args.ArgumentMarshaler am = marshalers.get(arg);
    3.     try {
    4.         return am == null ? 0 : (Double) am.get();
    5.     } catch (Exception e) {
    6.         return 0.0;
    7.     }
    8. }

    And all the tests pass! That was pretty painless. So now let’s make sure all the error processing works correctly. The next test case checks that an error is declared if an unparseable string is fed to a ## argument.

    1. public void testInvalidDouble() throws Exception {
    2.     Args args = new Args("x##", new String[]{"-x", "Forty two"});
    3.     assertFalse(args.isValid());
    4.     assertEquals(0, args.cardinality());
    5.     assertFalse(args.has('x'));
    6.     assertEquals(0, args.getInt('x'));
    7.     assertEquals("Argument -x expects a double but was ‘Forty two'.",
    8.             args.errorMessage());
    9. }
    11. ---
    13. public String errorMessage() throws Exception {
    14.     switch (errorCode) {
    15.         case OK:
    16.             throw new Exception("TILT: Should not get here.");
    17.         case UNEXPECTED_ARGUMENT:
    18.             return unexpectedArgumentMessage();
    19.         case MISSING_STRING:
    20.             return String.format("Could not find string parameter for -%c.",
    21.                     errorArgumentId);
    22.         case INVALID_INTEGER:
    23.             return String.format("Argument -%c expects an integer but was ‘%s’.",
    24.                     errorArgumentId, errorParameter);
    25.         case MISSING_INTEGER:
    26.             return String.format("Could not find integer parameter for -%c.",
    27.                     errorArgumentId);
    28.         case INVALID_DOUBLE:
    29.             return String.format("Argument -%c expects a double but was ‘%s’.",
    30.                     errorArgumentId, errorParameter);
    31.         case MISSING_DOUBLE:
    32.             return String.format("Could not find double parameter for -%c.",
    33.                     errorArgumentId);
    34.     }
    35.     return "";
    36. }

    And the tests pass. The next test makes sure we detect a missing double argument properly.

    1. public void testMissingDouble() throws Exception {
    2.     Args args = new Args("x##", new String[]{"-x"});
    3.     assertFalse(args.isValid());
    4.     assertEquals(0, args.cardinality());
    5.     assertFalse(args.has('x'));
    6.     assertEquals(0.0, args.getDouble('x'), 0.01);
    7.     assertEquals("Could not find double parameter for -x.",
    8.             args.errorMessage());
    9. }

    This passes as expected. We wrote it simply for completeness.

    The exception code is pretty ugly and doesn’t really belong in the Args class. We are also throwing out ParseException, which doesn’t really belong to us. So let’s merge all the exceptions into a single ArgsException class and move it into its own module.

    1. public class ArgsException extends Exception {
    2.     private char errorArgumentId = '\0';
    3.     private String errorParameter = "TILT";
    4.     private ErrorCode errorCode = ErrorCode.OK;
    6.     public ArgsException() {
    7.     }
    9.     public ArgsException(String message) {
    10.         super(message);
    11.     }
    13.     public enum ErrorCode {
    14.         OK, MISSING_STRING, MISSING_INTEGER,
    15.         INVALID_INTEGER, UNEXPECTED_ARGUMENT,
    16.         MISSING_DOUBLE, INVALID_DOUBLE
    17.     }
    18. }
    20. ---
    22. public class Args {
    23.      …
    24.     private char errorArgumentId = '\0';
    25.     private String errorParameter = "TILT";
    26.     private ArgsException.ErrorCode errorCode = ArgsException.ErrorCode.OK;
    27.     private List<String> argsList;
    29.     public Args(String schema, String[] args) throws ArgsException {
    30.         this.schema = schema;
    31.         argsList = Arrays.asList(args);
    32.         valid = parse();
    33.     }
    35.     private boolean parse() throws ArgsException {
    36.         if (schema.length() == 0 && argsList.size() == 0)
    37.             return true;
    38.         parseSchema();
    39.         try {
    40.             parseArguments();
    41.         } catch (ArgsException e) {
    42.         }
    43.         return valid;
    44.     }
    46.     private boolean parseSchema() throws ArgsException {
    47.        …
    48.     }
    50.     private void parseSchemaElement(String element) throws ArgsException {
    51.        …
    52.        else
    53.         throw new ArgsException(
    54.                 String.format("Argument: %c has invalid format: %s.",
    55.                         elementId, elementTail));
    56.     }
    58.     private void validateSchemaElementId(char elementId) throws ArgsException {
    59.         if (!Character.isLetter(elementId)) {
    60.             throw new ArgsException(
    61.                     "Bad character:" + elementId + "in Args format: " + schema);
    62.         }
    63.     }
    65.      …
    67.     private void parseElement(char argChar) throws ArgsException {
    68.         if (setArgument(argChar))
    69.             argsFound.add(argChar);
    70.         else {
    71.             unexpectedArguments.add(argChar);
    72.             errorCode = ArgsException.ErrorCode.UNEXPECTED_ARGUMENT;
    73.             valid = false;
    74.         }
    75.     }
    77.      …
    79.     private class StringArgumentMarshaler implements ArgumentMarshaler {
    80.         private String stringValue = "";
    82.         public void set(Iterator<String> currentArgument) throws ArgsException {
    83.             try {
    84.                 stringValue = currentArgument.next();
    85.             } catch (NoSuchElementException e) {
    86.                 errorCode = ArgsException.ErrorCode.MISSING_STRING;
    87.                 throw new ArgsException();
    88.             }
    89.         }
    91.         public Object get() {
    92.             return stringValue;
    93.         }
    94.     }
    96.     private class IntegerArgumentMarshaler implements ArgumentMarshaler {
    97.         private int intValue = 0;
    99.         public void set(Iterator<String> currentArgument) throws ArgsException {
    100.             String parameter = null;
    101.             try {
    102.                 parameter = currentArgument.next();
    103.                 intValue = Integer.parseInt(parameter);
    104.             } catch (NoSuchElementException e) {
    105.                 errorCode = ArgsException.ErrorCode.MISSING_INTEGER;
    106.                 throw new ArgsException();
    107.             } catch (NumberFormatException e) {
    108.                 errorParameter = parameter;
    109.                 errorCode = ArgsException.ErrorCode.INVALID_INTEGER;
    110.                 throw new ArgsException();
    111.             }
    112.         }
    114.         public Object get() {
    115.             return intValue;
    116.         }
    117.     }
    119.     private class DoubleArgumentMarshaler implements ArgumentMarshaler {
    120.         private double doubleValue = 0;
    122.         public void set(Iterator<String> currentArgument) throws ArgsException {
    123.             String parameter = null;
    124.             try {
    125.                 parameter = currentArgument.next();
    126.                 doubleValue = Double.parseDouble(parameter);
    127.             } catch (NoSuchElementException e) {
    128.                 errorCode = ArgsException.ErrorCode.MISSING_DOUBLE;
    129.                 throw new ArgsException();
    130.             } catch (NumberFormatException e) {
    131.                 errorParameter = parameter;
    132.                 errorCode = ArgsException.ErrorCode.INVALID_DOUBLE;
    133.                 throw new ArgsException();
    134.             }
    135.         }
    137.         public Object get() {
    138.             return doubleValue;
    139.         }
    140.     }
    141. }

    This is nice. Now the only exception thrown by Args is ArgsException. Moving ArgsException into its own module means that we can move a lot of the miscellaneous error support code into that module and out of the Args module. It provides a natural and obvious place to put all that code and will really help us clean up the Args module going forward.

    So now we have completely separated the exception and error code from the Args module. (See Listing 14-13 through Listing 14-16.) This was achieved through a series of about 30 tiny steps, keeping the tests passing between each step.

    Listing 14-13 ArgsTest.java

    1. package com.objectmentor.utilities.args;
    3. import junit.framework.TestCase;
    5. public class ArgsTest extends TestCase {
    6.     public void testCreateWithNoSchemaOrArguments() throws Exception {
    7.         Args args = new Args("", new String[0]);
    8.         assertEquals(0, args.cardinality());
    9.     }
    11.     public void testWithNoSchemaButWithOneArgument() throws Exception {
    12.         try {
    13.             new Args("", new String[]{"-x"});
    14.             fail();
    15.         } catch (ArgsException e) {
    16.             assertEquals(ArgsException.ErrorCode.UNEXPECTED_ARGUMENT,
    17.                     e.getErrorCode());
    18.             assertEquals('x', e.getErrorArgumentId());
    19.         }
    20.     }
    22.     public void testWithNoSchemaButWithMultipleArguments() throws Exception {
    23.         try {
    24.             new Args("", new String[]{"-x", "-y"});
    25.             fail();
    26.         } catch (ArgsException e) {
    27.             assertEquals(ArgsException.ErrorCode.UNEXPECTED_ARGUMENT,
    28.                     e.getErrorCode());
    29.             assertEquals('x', e.getErrorArgumentId());
    30.         }
    32.     }
    34.     public void testNonLetterSchema() throws Exception {
    35.         try {
    36.             new Args("*", new String[]{});
    37.             fail("Args constructor should have thrown exception");
    38.         } catch (ArgsException e) {
    40.             assertEquals(ArgsException.ErrorCode.INVALID_ARGUMENT_NAME,
    41.                     e.getErrorCode());
    42.             assertEquals('*', e.getErrorArgumentId());
    43.         }
    44.     }
    46.     public void testInvalidArgumentFormat() throws Exception {
    47.         try {
    48.             new Args("f~", new String[]{});
    49.             fail("Args constructor should have throws exception");
    50.         } catch (ArgsException e) {
    51.             assertEquals(ArgsException.ErrorCode.INVALID_FORMAT, e.getErrorCode());
    52.             assertEquals('f', e.getErrorArgumentId());
    53.         }
    54.     }
    56.     public void testSimpleBooleanPresent() throws Exception {
    57.         Args args = new Args("x", new String[]{"-x"});
    58.         assertEquals(1, args.cardinality());
    59.         assertEquals(true, args.getBoolean('x'));
    60.     }
    62.     public void testSimpleStringPresent() throws Exception {
    63.         Args args = new Args("x*", new String[]{"-x", "param"});
    64.         assertEquals(1, args.cardinality());
    65.         assertTrue(args.has('x'));
    66.         assertEquals("param", args.getString('x'));
    67.     }
    69.     public void testMissingStringArgument() throws Exception {
    70.         try {
    71.             new Args("x*", new String[]{"-x"});
    72.             fail();
    73.         } catch (ArgsException e) {
    74.             assertEquals(ArgsException.ErrorCode.MISSING_STRING, e.getErrorCode());
    75.             assertEquals('x', e.getErrorArgumentId());
    76.         }
    77.     }
    79.     public void testSpacesInFormat() throws Exception {
    80.         Args args = new Args("x, y", new String[]{"-xy"});
    81.         assertEquals(2, args.cardinality());
    82.         assertTrue(args.has('x'));
    83.         assertTrue(args.has('y'));
    84.     }
    86.     public void testSimpleIntPresent() throws Exception {
    87.         Args args = new Args("x#", new String[]{"-x", "42"});
    88.         assertEquals(1, args.cardinality());
    89.         assertTrue(args.has('x'));
    90.         assertEquals(42, args.getInt('x'));
    91.     }
    93.     public void testInvalidInteger() throws Exception {
    94.         try {
    95.             new Args("x#", new String[]{"-x", "Forty two"});
    97.             fail();
    98.         } catch (ArgsException e) {
    99.             assertEquals(ArgsException.ErrorCode.INVALID_INTEGER, e.getErrorCode());
    100.             assertEquals('x', e.getErrorArgumentId());
    101.             assertEquals("Forty two", e.getErrorParameter());
    102.         }
    104.     }
    106.     public void testMissingInteger() throws Exception {
    107.         try {
    108.             new Args("x#", new String[]{"-x"});
    109.             fail();
    110.         } catch (ArgsException e) {
    111.             assertEquals(ArgsException.ErrorCode.MISSING_INTEGER, e.getErrorCode());
    112.             assertEquals('x', e.getErrorArgumentId());
    113.         }
    114.     }
    116.     public void testSimpleDoublePresent() throws Exception {
    117.         Args args = new Args("x##", new String[]{"-x", "42.3"});
    118.         assertEquals(1, args.cardinality());
    119.         assertTrue(args.has('x'));
    120.         assertEquals(42.3, args.getDouble('x'), .001);
    121.     }
    123.     public void testInvalidDouble() throws Exception {
    124.         try {
    125.             new Args("x##", new String[]{"-x", "Forty two"});
    126.             fail();
    127.         } catch (ArgsException e) {
    128.             assertEquals(ArgsException.ErrorCode.INVALID_DOUBLE, e.getErrorCode());
    129.             assertEquals('x', e.getErrorArgumentId());
    130.             assertEquals("Forty two", e.getErrorParameter());
    131.         }
    132.     }
    134.     public void testMissingDouble() throws Exception {
    135.         try {
    136.             new Args("x##", new String[]{"-x"});
    137.             fail();
    138.         } catch (ArgsException e) {
    139.             assertEquals(ArgsException.ErrorCode.MISSING_DOUBLE, e.getErrorCode());
    140.             assertEquals('x', e.getErrorArgumentId());
    141.         }
    142.     }
    143. }

    Listing 14-14 ArgsExceptionTest.java

    1. public class ArgsExceptionTest extends TestCase {
    2.     public void testUnexpectedMessage() throws Exception {
    3.         ArgsException e =
    5.                 new ArgsException(ArgsException.ErrorCode.UNEXPECTED_ARGUMENT,
    6.                         'x', null);
    7.         assertEquals("Argument -x unexpected.", e.errorMessage());
    8.     }
    10.     public void testMissingStringMessage() throws Exception {
    11.         ArgsException e = new ArgsException(ArgsException.ErrorCode.MISSING_STRING,
    12.                 'x', null);
    13.         assertEquals("Could not find string parameter for -x.", e.errorMessage());
    14.     }
    16.     public void testInvalidIntegerMessage() throws Exception {
    17.         ArgsException e =
    18.                 new ArgsException(ArgsException.ErrorCode.INVALID_INTEGER,
    19.                         'x', "Forty two");
    20.         assertEquals("Argument -x expects an integer but was 'Forty two'.",
    21.                 e.errorMessage());
    22.     }
    24.     public void testMissingIntegerMessage() throws Exception {
    25.         ArgsException e =
    26.                 new ArgsException(ArgsException.ErrorCode.MISSING_INTEGER, 'x', null);
    27.         assertEquals("Could not find integer parameter for -x.", e.errorMessage());
    28.     }
    30.     public void testInvalidDoubleMessage() throws Exception {
    31.         ArgsException e = new ArgsException(ArgsException.ErrorCode.INVALID_DOUBLE,
    32.                 'x', "Forty two");
    33.         assertEquals("Argument -x expects a double but was 'Forty two'.",
    34.                 e.errorMessage());
    35.     }
    37.     public void testMissingDoubleMessage() throws Exception {
    38.         ArgsException e = new ArgsException(ArgsException.ErrorCode.MISSING_DOUBLE,
    39.                 'x', null);
    40.         assertEquals("Could not find double parameter for -x.", e.errorMessage());
    41.     }
    42. }

    Listing 14-15 ArgsException.java

    1. public class ArgsException extends Exception {
    2.     private char errorArgumentId = '\0';
    3.     private String errorParameter = "TILT";
    4.     private ErrorCode errorCode = ErrorCode.OK;
    6.     public ArgsException() {
    7.     }
    9.     public ArgsException(String message) {
    10.         super(message);
    11.     }
    13.     public ArgsException(ErrorCode errorCode) {
    14.         this.errorCode = errorCode;
    15.     }
    17.     public ArgsException(ErrorCode errorCode, String errorParameter) {
    18.         this.errorCode = errorCode;
    19.         this.errorParameter = errorParameter;
    20.     }
    22.     public ArgsException(ErrorCode errorCode, char errorArgumentId,
    23.                          String errorParameter) {
    24.         this.errorCode = errorCode;
    25.         this.errorParameter = errorParameter;
    26.         this.errorArgumentId = errorArgumentId;
    27.     }
    29.     public char getErrorArgumentId() {
    30.         return errorArgumentId;
    31.     }
    33.     public void setErrorArgumentId(char errorArgumentId) {
    34.         this.errorArgumentId = errorArgumentId;
    35.     }
    37.     public String getErrorParameter() {
    38.         return errorParameter;
    39.     }
    41.     public void setErrorParameter(String errorParameter) {
    42.         this.errorParameter = errorParameter;
    43.     }
    45.     public ErrorCode getErrorCode() {
    46.         return errorCode;
    47.     }
    49.     public void setErrorCode(ErrorCode errorCode) {
    50.         this.errorCode = errorCode;
    51.     }
    53.     public String errorMessage() throws Exception {
    54.         switch (errorCode) {
    55.             case OK:
    56.                 throw new Exception("TILT: Should not get here.");
    57.             case UNEXPECTED_ARGUMENT:
    58.                 return String.format("Argument -%c unexpected.", errorArgumentId);
    59.             case MISSING_STRING:
    60.                 return String.format("Could not find string parameter for -%c.",
    61.                         errorArgumentId);
    62.             case INVALID_INTEGER:
    63.                 return String.format("Argument -%c expects an integer but was '%s'.",
    64.                         errorArgumentId, errorParameter);
    65.             case MISSING_INTEGER:
    66.                 return String.format("Could not find integer parameter for -%c.",
    67.                         errorArgumentId);
    68.             case INVALID_DOUBLE:
    69.                 return String.format("Argument -%c expects a double but was '%s'.",
    70.                         errorArgumentId, errorParameter);
    72.             case MISSING_DOUBLE:
    73.                 return String.format("Could not find double parameter for -%c.",
    74.                         errorArgumentId);
    75.         }
    76.         return "";
    77.     }
    79.     public enum ErrorCode {
    80.         OK, INVALID_FORMAT, UNEXPECTED_ARGUMENT, INVALID_ARGUMENT_NAME,
    81.         MISSING_STRING,
    82.         MISSING_INTEGER, INVALID_INTEGER,
    83.         MISSING_DOUBLE, INVALID_DOUBLE
    84.     }
    85. }

    Listing 14-16 Args.java

    1. public class Args {
    2.     private String schema;
    3.     private Map<Character, ArgumentMarshaler> marshalers =
    4.             new HashMap<Character, ArgumentMarshaler>();
    5.     private Set<Character> argsFound = new HashSet<Character>();
    6.     private Iterator<String> currentArgument;
    7.     private List<String> argsList;
    9.     public Args(String schema, String[] args) throws ArgsException {
    10.         this.schema = schema;
    11.         argsList = Arrays.asList(args);
    12.         parse();
    13.     }
    15.     private void parse() throws ArgsException {
    16.         parseSchema();
    17.         parseArguments();
    18.     }
    20.     private boolean parseSchema() throws ArgsException {
    21.         for (String element : schema.split(",")) {
    22.             if (element.length() > 0) {
    23.                 parseSchemaElement(element.trim());
    24.             }
    25.         }
    26.         return true;
    27.     }
    29.     private void parseSchemaElement(String element) throws ArgsException {
    30.         char elementId = element.charAt(0);
    31.         String elementTail = element.substring(1);
    32.         validateSchemaElementId(elementId);
    33.         if (elementTail.length() == 0)
    34.             marshalers.put(elementId, new BooleanArgumentMarshaler());
    35.         else if (elementTail.equals("*"))
    36.             marshalers.put(elementId, new StringArgumentMarshaler());
    38.         else if (elementTail.equals("#"))
    39.             marshalers.put(elementId, new IntegerArgumentMarshaler());
    40.         else if (elementTail.equals("##"))
    41.             marshalers.put(elementId, new DoubleArgumentMarshaler());
    42.         else
    43.             throw new ArgsException(ArgsException.ErrorCode.INVALID_FORMAT,
    44.                     elementId, elementTail);
    45.     }
    47.     private void validateSchemaElementId(char elementId) throws ArgsException {
    48.         if (!Character.isLetter(elementId)) {
    49.             throw new ArgsException(ArgsException.ErrorCode.INVALID_ARGUMENT_NAME,
    50.                     elementId, null);
    51.         }
    52.     }
    54.     private void parseArguments() throws ArgsException {
    55.         for (currentArgument = argsList.iterator(); currentArgument.hasNext(); ) {
    56.             String arg = currentArgument.next();
    57.             parseArgument(arg);
    58.         }
    59.     }
    61.     private void parseArgument(String arg) throws ArgsException {
    62.         if (arg.startsWith("-"))
    63.             parseElements(arg);
    64.     }
    66.     private void parseElements(String arg) throws ArgsException {
    67.         for (int i = 1; i < arg.length(); i++)
    68.             parseElement(arg.charAt(i));
    69.     }
    71.     private void parseElement(char argChar) throws ArgsException {
    72.         if (setArgument(argChar))
    73.             argsFound.add(argChar);
    74.         else {
    75.             throw new ArgsException(ArgsException.ErrorCode.UNEXPECTED_ARGUMENT,
    76.                     argChar, null);
    77.         }
    78.     }
    80.     private boolean setArgument(char argChar) throws ArgsException {
    81.         ArgumentMarshaler m = marshalers.get(argChar);
    82.         if (m == null)
    83.             return false;
    84.         try {
    85.             m.set(currentArgument);
    86.             return true;
    87.         } catch (ArgsException e) {
    88.             e.setErrorArgumentId(argChar);
    89.             throw e;
    90.         }
    91.     }
    93.     public int cardinality() {
    94.         return argsFound.size();
    95.     }
    97.     public String usage() {
    98.         if (schema.length() > 0)
    99.             return "-[" + schema + "]";
    100.         else
    101.             return "";
    102.     }
    104.     public boolean getBoolean(char arg) {
    105.         ArgumentMarshaler am = marshalers.get(arg);
    106.         boolean b = false;
    107.         try {
    108.             b = am != null && (Boolean) am.get();
    109.         } catch (ClassCastException e) {
    110.             b = false;
    111.         }
    112.         return b;
    113.     }
    115.     public String getString(char arg) {
    116.         ArgumentMarshaler am = marshalers.get(arg);
    117.         try {
    118.             return am == null ? "" : (String) am.get();
    119.         } catch (ClassCastException e) {
    120.             return "";
    121.         }
    122.     }
    124.     public int getInt(char arg) {
    125.         ArgumentMarshaler am = marshalers.get(arg);
    126.         try {
    127.             return am == null ? 0 : (Integer) am.get();
    128.         } catch (Exception e) {
    129.             return 0;
    130.         }
    131.     }
    134.     public double getDouble(char arg) {
    135.         ArgumentMarshaler am = marshalers.get(arg);
    136.         try {
    137.             return am == null ? 0 : (Double) am.get();
    138.         } catch (Exception e) {
    139.             return 0.0;
    140.         }
    141.     }
    143.     public boolean has(char arg) {
    144.         return argsFound.contains(arg);
    145.     }

    The majority of the changes to the Args class were deletions. A lot of code just got moved out of Args and put into ArgsException. Nice. We also moved all the ArgumentMarshaller s into their own files. Nicer!

    Much of good software design is simply about partitioning—creating appropriate places to put different kinds of code. This separation of concerns makes the code much simpler to understand and maintain.

    Of special interest is the errorMessage method of ArgsException. Clearly it was a violation of the SRP to put the error message formatting into Args. Args should be about the processing of arguments, not about the format of the error messages. However, does it really make sense to put the error message formatting code into ArgsException?

    Frankly, it’s a compromise. Users who don’t like the error messages supplied by ArgsException will have to write their own. But the convenience of having canned error messages already prepared for you is not insignificant.

    By now it should be clear that we are within striking distance of the final solution that appeared at the start of this chapter. I’ll leave the final transformations to you as an exercise.

    CONCLUSION It is not enough for code to work. Code that works is often badly broken. Programmers who satisfy themselves with merely working code are behaving unprofessionally. They may fear that they don’t have time to improve the structure and design of their code, but I disagree. Nothing has a more profound and long-term degrading effect upon a development project than bad code. Bad schedules can be redone, bad requirements can be redefined. Bad team dynamics can be repaired. But bad code rots and ferments, becoming an inexorable weight that drags the team down. Time and time again I have seen teams grind to a crawl because, in their haste, they created a malignant morass of code that forever thereafter dominated their destiny.

    So the solution is to continuously keep your code as clean and simple as it can be. Never let the rot get started.